Statement store e2e integration tests lite person setup#11415
Open
DenzelPenzel wants to merge 11 commits intomasterfrom
Open
Statement store e2e integration tests lite person setup#11415DenzelPenzel wants to merge 11 commits intomasterfrom
DenzelPenzel wants to merge 11 commits intomasterfrom
Conversation
DenzelPenzel
force-pushed
the
denzelpenzel/statement-store-e2e-integration-tests-lite-person-setup
branch
from
05532ab to
03a88f8
Compare
Contributor
Author
|
/cmd fmt |
DenzelPenzel
force-pushed
the
denzelpenzel/statement-store-e2e-integration-tests-lite-person-setup
branch
from
c8630e2 to
040103f
Compare
Contributor
Author
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
…ent-store-e2e-integration-tests-lite-person-setup # Conflicts: # .github/zombienet-tests/zombienet_cumulus_tests.yml # cumulus/zombienet/zombienet-sdk/tests/zombie_ci/statement_store/integration.rs
Contributor
Author
|
/cmd fmt |
s0me0ne-unkn0wn
approved these changes
Apr 14, 2026
Contributor
s0me0ne-unkn0wn
left a comment
s0me0ne-unkn0wn
left a comment
There was a problem hiding this comment.
Looks good! We still need to sudo to get the attestation allowance, and I wonder how it works in the real world. If that requires some deposit bonding, we could implement even that 🙃
alexggh
reviewed
Apr 14, 2026
| assert!(entry.is_some(), "Candidate should be registered in LitePeople storage"); | ||
| info!("Verified: candidate is present in LitePeople storage"); | ||
|
|
||
| // Wait for the attest block to finalize before submitting statements |
Contributor
There was a problem hiding this comment.
We actually need to test this: #11667, that we don't have to wait for block to be finalized :D
Contributor
Author
There was a problem hiding this comment.
sure, I will prepare the separate PR for this!
Contributor
Author
|
/cmd fmt |
…ent-store-e2e-integration-tests-lite-person-setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary