Fix Compilation Issue: Define Correct Integer Type for Linux and Windows in droid_kernels.cu File #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a compilation issue in the CUDA droid_kernels.cu file that occurs when running setup.py on different operating systems. Previously, the build failed because long is 64-bit on Linux but not necessarily on Windows. This change ensures compatibility by defining LongType as:
Changes
Why This Fix?
The previous implementation led to setup.py compilation failures on Windows due to type mismatches, as seen in #39 . Using #ifdef ensures consistency across platforms.
Testing