Skip to content

Sandboxed iframes breaks saveCanvas() function #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
emilyweil opened this issue Jul 13, 2021 · 9 comments · Fixed by #1901
Closed

Sandboxed iframes breaks saveCanvas() function #1899

emilyweil opened this issue Jul 13, 2021 · 9 comments · Fixed by #1901

Comments

@emilyweil
Copy link

I'm seeing the same issue reported here:
#1443 (comment)

@welcome
Copy link

welcome bot commented Jul 13, 2021

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@wildparadox
Copy link

Found this through #1443 as well. Despite that issue being closed, save() doesn't work in the web editor either for the same reason.

@catarak
Copy link
Member

catarak commented Jul 15, 2021

Thank you for reporting! I see that I removed allow-downloads from the list of sandbox attributes, but it can be added in again.

@emilyweil
Copy link
Author

Thanks so much! I'm yearning to saveCanvas().

@catarak
Copy link
Member

catarak commented Jul 15, 2021

While you're waiting for this fix to be deployed, you can right click on a canvas to save it, though it is obviously not ideal :)

@emilyweil
Copy link
Author

I'm saving a canvas repeatedly as I draw to it so when saveCanvas() becomes available, I'll be very happy – thanks again!

catarak added a commit that referenced this issue Jul 15, 2021
[#1899] Add allow-downloads to iframe sandbox attributes
@catarak
Copy link
Member

catarak commented Jul 15, 2021

Just did a hotfix release so this should be deployed to production shortly 😄

@emilyweil
Copy link
Author

That's really great – thank you!

@emilyweil
Copy link
Author

SaveCanvas() is working beautifully. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants