Skip to content

Color of checkbox should be of p5 editor's theme but its not #2808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PiyushThapaa opened this issue Dec 30, 2023 · 3 comments · Fixed by #2811
Closed

Color of checkbox should be of p5 editor's theme but its not #2808

PiyushThapaa opened this issue Dec 30, 2023 · 3 comments · Fixed by #2811
Assignees
Labels
Bug Error or unexpected behaviors

Comments

@PiyushThapaa
Copy link
Contributor

p5.js version

No response

What is your operating system?

Windows

Web browser and version

Chrome

Actual Behavior

Screenshot 2023-12-30 183221

The color of checkbox should be of p5 editor's theme according to this code but this code is not working and the color of checkbox is default

Expected Behavior

recording-2023-12-30-18-42-34.mp4

The expected behaviour should be like this...

Steps to reproduce

Steps:

  1. Go to the p5 web editor website
  2. In tool section below the header, there is a checkbox
@PiyushThapaa PiyushThapaa added the Bug Error or unexpected behaviors label Dec 30, 2023
@PiyushThapaa PiyushThapaa reopened this Dec 30, 2023
@PiyushThapaa
Copy link
Contributor Author

@lindapaiste please assign this to me

@mayanksahu17
Copy link

hey I can fix this issue. Can u assign me ?

@lindapaiste
Copy link
Collaborator

lindapaiste commented Dec 30, 2023

Can you please explain what you are showing in the video that isn't right? Because it looks correct to me. I see a pink checkbox next to "Auto-refresh". Then you change the theme to "dark" mode and it is pink. Then to "contrast" and it is yellow. That's all correct.

Ohhhh your video is showing the expected behavior. Nevermind!

lindapaiste added a commit that referenced this issue Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Error or unexpected behaviors
Projects
None yet
3 participants