Update _toolbar.scss #2810
Closed
Update _toolbar.scss #2810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Color of checkbox changed to p5 editor's theme color
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
lindapaiste
reviewed
Dec 30, 2023
There was a problem hiding this comment.
This is not how the the themify variables work. The argument of the getThemifyVariable function is the name of the theme variable, not a color code. We don't hard-code the colors into the CSS because we want it to vary by theme. We define the colors for each theme in the _variables.scss file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Color of checkbox changed to p5 editor's theme color
Fixes #2808
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123