Run preTest actions during release verification workflow #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ci-mgmt config has a configuration property for `preTest` jobs. These are run during the `test` workflow before the tests themselves are run. Since the verify release workflow runs the same tests we should also run these `preTest` steps. For example, in `pulumi-aws` we have `preTest` jobs to get AWS credentials which are required to run the tests in the verify release workflow. re pulumi/pulumi-aws#5049, re #1265
iwahbe
approved these changes
Jan 8, 2025
Member
iwahbe
left a comment
iwahbe
left a comment
There was a problem hiding this comment.
This is stretching the definition of .Config.Actions.PreTest, but since release verification is basically just running an example test, I think this is ok.
Contributor
|
@corymhall we might need to revert this as it's caused a P1 in azure – master is broken. Pre-test currently has the assumption that it's only run in the test job, which has some addition setup including gotestfmt. I would agree this is a slightly odd place to call preTest as release verification isn't running any tests - just downloading and executing the released SDKs and provider binary.
I don't think this is true. We don't run any Go tests in the verify job. |
danielrbradley
added a commit
that referenced
this pull request
Jan 10, 2025
…)" This reverts commit 8531096.
iwahbe
added a commit
to pulumi/pulumi-junipermist
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-scm
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-meraki
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-sdwan
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-ise
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-dbtcloud
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-harness
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-artifactory
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-pagerduty
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-okta
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-pagerduty
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-auth0
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-datadog
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-tailscale
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-vault
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-okta
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-gitlab
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-postgresql
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-snowflake
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-newrelic
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-auth0
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-hcloud
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-cloudflare
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-vault
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-datadog
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-postgresql
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-gitlab
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-hcloud
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-digitalocean
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-cloudflare
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
iwahbe
added a commit
to pulumi/pulumi-digitalocean
that referenced
this pull request
Jan 10, 2025
By using ci-mgmt's intended solution for running integration tests in the `provider/` directory, we get a maintained test script and avoid overloading the `actions.preTest` hook to run tests. Related to pulumi/ci-mgmt#1276, pulumi/ci-mgmt#1274 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ci-mgmt config has a configuration property for
preTestjobs. These are run during thetestworkflow before the tests themselves are run. Since the verify release workflow runs the same tests we should also run thesepreTeststeps. For example, inpulumi-awswe havepreTestjobs to get AWS credentials which are required to run the tests in the verify release workflow.re pulumi/pulumi-aws#5049, re #1265