Revert "chore: enable release verifcation" #5049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 409cf93.
corymhall
approved these changes
Jan 8, 2025
flostadler
approved these changes
Jan 8, 2025
corymhall
added a commit
to pulumi/ci-mgmt
that referenced
this pull request
Jan 8, 2025
The ci-mgmt config has a configuration property for `preTest` jobs. These are run during the `test` workflow before the tests themselves are run. Since the verify release workflow runs the same tests we should also run these `preTest` steps. For example, in `pulumi-aws` we have `preTest` jobs to get AWS credentials which are required to run the tests in the verify release workflow. re pulumi/pulumi-aws#5049, re #1265
Does the PR have any schema changes?Looking good! No breaking changes found. Maintainer note: consult the runbook for dealing with any breaking changes. |
corymhall
requested changes
Jan 8, 2025
Contributor
corymhall
left a comment
corymhall
left a comment
There was a problem hiding this comment.
Holding off on merging for now, I might have a fix that we can merge instead.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5049 +/- ##
=======================================
Coverage 24.42% 24.42%
=======================================
Files 360 360
Lines 143403 143403
=======================================
Hits 35023 35023
Misses 108281 108281
Partials 99 99 ☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
to pulumi/ci-mgmt
that referenced
this pull request
Jan 8, 2025
The ci-mgmt config has a configuration property for `preTest` jobs. These are run during the `test` workflow before the tests themselves are run. Since the verify release workflow runs the same tests we should also run these `preTest` steps. For example, in `pulumi-aws` we have `preTest` jobs to get AWS credentials which are required to run the tests in the verify release workflow. re pulumi/pulumi-aws#5049, re #1265
Contributor
|
This PR has been shipped in release v6.66.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5034
This did not quite work yet per:
#5044