Fix zero_start_index_M argument for triton rowwise quantize #3639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D68872138 |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Jan 30, 2025
…3639) Summary: X-link: facebookresearch/FBGEMM#714 D68797978 implemented a new feature that allowed partial rowwise quantization for jagged tensors in the hopes of improving MOE performance. However, it operated on the wrong dimension (oops). This update shifts the dimension to the proper per-group non zero row. Differential Revision: D68872138
jwfromm
force-pushed
the
export-D68872138
branch
from
dbcc97b to
830c2ee
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68872138 |
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Jan 31, 2025
…3639) Summary: X-link: facebookresearch/FBGEMM#714 D68797978 implemented a new feature that allowed partial rowwise quantization for jagged tensors in the hopes of improving MOE performance. However, it operated on the wrong dimension (oops). This update shifts the dimension to the proper per-group non zero row. Reviewed By: jasonjk-park, jiawenliu64 Differential Revision: D68872138
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Jan 31, 2025
…3639) Summary: X-link: facebookresearch/FBGEMM#714 D68797978 implemented a new feature that allowed partial rowwise quantization for jagged tensors in the hopes of improving MOE performance. However, it operated on the wrong dimension (oops). This update shifts the dimension to the proper per-group non zero row. Reviewed By: jasonjk-park, jiawenliu64 Differential Revision: D68872138
Summary: X-link: facebookresearch/FBGEMM#695 This diff is the nvidia mirror of D68686266, which changes dynamic grouped gemm to return a tensor of shape [total_M, N] when zero_start_index_M isnt provided. We also add appropriate tests to make sure the behavior doesnt break going forward. Reviewed By: jasonjk-park, jianyuh, jiawenliu64 Differential Revision: D68689077
…3639) Summary: X-link: facebookresearch/FBGEMM#714 D68797978 implemented a new feature that allowed partial rowwise quantization for jagged tensors in the hopes of improving MOE performance. However, it operated on the wrong dimension (oops). This update shifts the dimension to the proper per-group non zero row. Reviewed By: jasonjk-park, jiawenliu64 Differential Revision: D68872138
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Feb 3, 2025
…3639) Summary: X-link: facebookresearch/FBGEMM#714 D68797978 implemented a new feature that allowed partial rowwise quantization for jagged tensors in the hopes of improving MOE performance. However, it operated on the wrong dimension (oops). This update shifts the dimension to the proper per-group non zero row. Reviewed By: jasonjk-park, jiawenliu64 Differential Revision: D68872138
jwfromm
force-pushed
the
export-D68872138
branch
from
830c2ee to
37cc6b3
Compare
jwfromm
added a commit
to jwfromm/FBGEMM
that referenced
this pull request
Feb 3, 2025
…3639) Summary: X-link: facebookresearch/FBGEMM#714 D68797978 implemented a new feature that allowed partial rowwise quantization for jagged tensors in the hopes of improving MOE performance. However, it operated on the wrong dimension (oops). This update shifts the dimension to the proper per-group non zero row. Reviewed By: jasonjk-park, jiawenliu64 Differential Revision: D68872138
|
This pull request was exported from Phabricator. Differential Revision: D68872138 |
|
This pull request has been merged in 26eeef0. |
avbokovoy
pushed a commit
to ROCm/FBGEMM
that referenced
this pull request
Feb 14, 2025
…3639) Summary: Pull Request resolved: pytorch#3639 X-link: https://github.com/facebookresearch/FBGEMM/pull/714 D68797978 implemented a new feature that allowed partial rowwise quantization for jagged tensors in the hopes of improving MOE performance. However, it operated on the wrong dimension (oops). This update shifts the dimension to the proper per-group non zero row. Reviewed By: jasonjk-park, jiawenliu64 Differential Revision: D68872138 fbshipit-source-id: 92afb61da24cd9d85603b30e0baaa9685ba51c8d
q10
pushed a commit
to q10/FBGEMM
that referenced
this pull request
Apr 10, 2025
) Summary: X-link: pytorch#3639 Pull Request resolved: facebookresearch/FBGEMM#714 D68797978 implemented a new feature that allowed partial rowwise quantization for jagged tensors in the hopes of improving MOE performance. However, it operated on the wrong dimension (oops). This update shifts the dimension to the proper per-group non zero row. Reviewed By: jasonjk-park, jiawenliu64 Differential Revision: D68872138 fbshipit-source-id: 92afb61da24cd9d85603b30e0baaa9685ba51c8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/714
D68797978 implemented a new feature that allowed partial rowwise quantization for jagged tensors in the hopes of improving MOE performance. However, it operated on the wrong dimension (oops). This update shifts the dimension to the proper per-group non zero row.
Differential Revision: D68872138