Deprecate the final_step_result parameter of TrialResult #5281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@95-martin-orion This ended up being bigger than I thought, but should end up making things simpler once all these things get fully removed. The removal of mocks from a bunch of tests is a good sign. No rush on this one. |
95-martin-orion
approved these changes
Apr 22, 2022
| @@ -876,6 +889,55 @@ def sample_measurement_ops( | |||
| ) | |||
|
|
|||
|
|
|||
| # When removing this, also remove the check in simulate_sweep_iter. | |||
| # Basically there should be no "final_step_result" anywhere in the project afterwards. | |||
| def _deprecated_step_result_parameter( | |||
There was a problem hiding this comment.
The intent is to remove this method after the next release, right?
There was a problem hiding this comment.
Yes, this was purely to reduce the redundancy of those deprecation attributes. It's not intended to be general purpose or used for anything else ever, and will go away when the deprecated parameters do.
There was a problem hiding this comment.
After this, #5270 will be a small PR, then ActOnArgs rename after that.
95-martin-orion
added
the
automerge
CirqBot
added
the
front_of_queue_automerge
CirqBot
removed
automerge
rht
pushed a commit
to rht/Cirq
that referenced
this pull request
May 1, 2023
…5281) Follow-up to quantumlib#5260, as that PR makes final_step_result unnecessary. Also deprecate DensityMatrixSimulatorState and StateVectorSimulatorState Closes quantumlib#5271
harry-phasecraft
pushed a commit
to PhaseCraft/Cirq
that referenced
this pull request
Oct 31, 2024
…5281) Follow-up to quantumlib#5260, as that PR makes final_step_result unnecessary. Also deprecate DensityMatrixSimulatorState and StateVectorSimulatorState Closes quantumlib#5271
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5260, as that PR makes final_step_result unnecessary.
Also deprecate DensityMatrixSimulatorState and StateVectorSimulatorState
Closes #5271