Update versions of dependencies & regenerate envs/*.txt files #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure why it wasn't executable, and I don't see a reason why it shouldn't be.
This updates many versions of Python packages in the requirements files, and includes refreshed outputs from the pip-compile script.
The Pylint config file for 3.x has considerably changed from 2.x. The `.pylintrc` in this commit has many checks turned off. I ran `pylint` 3.3.3 repeatedly on the codebase, checking whether the warnings looked serious. For many that looked like probable code errors, I opened issues, but the work is incomplete. In the end I started disabling most checks because there was too much to do and we were aiming to do a release asap. We need to go back, re-enable checks in .pylintrc one by one, and correct the warnings in the code.
This is not complete, but these are all the ones I could find for things that were flagged as missing by mypy. For those that I couldn’t find, I added exceptions in ../../conf/mypy.ini.
Seems that python 3.12 deprecated a function. For now, I disabled deprecated function checks.
There are still a couple of hundred errors reported by mypy. In the interest of getting the next release out today, I set `ignore_errors` to True. TODO: come back and re-enable errors after the next release.
A conflict between some packages and jax/jaxlib 0.5.x showed up on the GitHub runners. I didn't experience the same locally, but it doesn't look it's a problem to go down to 0.4.38, so let's do that.
Pylint needs to import the python packages used in modules it checks. Some of what it needs are only imported by other requirements files, so the pylint one has to reference the others.
This updates them to the latest output of pip-compile given the most recent edits to the individual dependency files.
ncrubin
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates many versions of Python packages in the requirements files, and includes refreshed outputs from the pip-compile script.
Due to changes in Pylint and Mypy, the version updates also required updates to their respective configuration files. Even though it would probably have been better to separate those changes into different PRs, the problem is that updating pylint & mypy requires also re-running the pip-compile process to produce the various env requirements files. This interdependency is why the config file updates are part of this PR.