(feat) Add support for xautoclaim to return list of deleted messages ids from PEL#3798
(feat) Add support for xautoclaim to return list of deleted messages ids from PEL#3798ndyakov merged 13 commits intoredis:masterfrom
Conversation
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
|
Thank you @Khukharr , we will look at this as soon as possible. |
Khukharr
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6606533. Configure here.
|
I seem to be hitting what I could consider intermittent issues trying to get CI to run. I don't know if I should keep on triggering CI until it all passes or leave it as is ? |
|
It looks like a data race while closing the pool, not related to this PR, will continue with a proper review of the changes and get back to you. |
|
btw, this should fix the CI: #3805 |
…d messages ids from PEL (redis#3798) * reading xautoclaim's 3rd return value as list of deletedIDs * adding test for xautoclaim that returns deletedIDs * updating expected comments. running doctests make test locally works fine ? * Adding missing clone deletedIDs * switch to creating a new command instead * output needed updating * forgot to add the XAutoClaimWithDelete command to StreamCmdable * Fix naming inconsistency in XAutoClaimWithDeleted * trigger CI * trigger CI * trigger CI * trigger CI --------- Co-authored-by: Benoit Verreault <benoit.verreault@gearbox.com> Co-authored-by: Nedyalko Dyakov <1547186+ndyakov@users.noreply.github.com>
2 participants
Since Redis 7.0,
XAUTOCLAIMnow returns a list of deleted message IDs as the 3rd part of the reply. Previously that part was discarded when received. This adds the ability to read those deleted message IDs and return them.See: https://redis.io/docs/latest/commands/xautoclaim/
Note
Medium Risk
Adds a new public stream command and command type to parse Redis 7+
XAUTOCLAIMreplies, touching reply parsing and cluster aggregation paths; mistakes could cause incorrect stream consumption behavior or aggregation failures.Overview
Adds Redis 7+ support for
XAUTOCLAIM’s third reply element (deleted PEL entry IDs) by introducingXAutoClaimWithDeleted/XAutoClaimWithDeletedCmd, which parses and returnsdeletedIDsinstead of discarding them.Updates command-type plumbing (
CmdTypeXAutoClaimWithDeleted, value extraction, and OSS cluster router command creation/value setting) and adds a regression test asserting deleted IDs are surfaced after anXDEL.Reviewed by Cursor Bugbot for commit 260293c. Bugbot is set up for automated code reviews on this repo. Configure here.