fix(pool): Fix Close. Do healthchecks only on idle conns#3805
Merged
fix(pool): Fix Close. Do healthchecks only on idle conns#3805
Conversation
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
ofekshenawa
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a rare corner case (actually observed in the CI), if the pool is closed while a connection is in use there will be a data race, since the connection that the pool.Close is trying to execute a healthcheck on (which peeks the socket) is currently being used.
Note
Medium Risk
Changes shutdown behavior in the connection pool by skipping socket/reader peeks for non-idle connections, which reduces race risk but could mask close errors for in-use connections during
Close().Overview
Fixes a shutdown-time data race by changing
ConnPool.Close()to runisHealthyConnonly for connections that are currently idle, and to treat non-idle connections as healthy for the purpose of deciding whether to surface close errors.Also updates
Conn.readerMudocumentation to reflect that the reader lock is used for both handoff and health-check-related peek operations.Reviewed by Cursor Bugbot for commit 91a40cf. Bugbot is set up for automated code reviews on this repo. Configure here.