-
Notifications
You must be signed in to change notification settings - Fork 690
[vernac] expose API to elaborate declarations #15872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Modulo the two nits this looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, @gares I assume you want to wait for the overlay, so I will wait to merge.
I'm not sure the code the last commit exposes is in the right place. Happy to move it elsewhere, just tell me where. |
3e1794e
to
003fb0c
Compare
6d3dcd2
to
d1d74f5
Compare
So, after more work on the overlay (which is not ready yet, but is converging), the exposed API is:
The latter one has a very nasty type, suggestions are welcome. The overall feeling is that having just one |
Thanks @gares will have a deeper look when the overlay is ready, but indeed I agree with your comments, we can do a lot of improvements in this area. For sure this PR will improve things already. |
I'm almost done with the overlay, sorry for taking so long, but it was not trivial. So far the API is sufficient, but I'm not done. |
No worries at all take your time! |
23ea0b2
to
f1e2d0c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
🔴 CI failure at commit f2ad35d without any failure in the test-suite ✔️ Corresponding job for the base commit f9c9ee5 succeeded ❔ Ask me to try to extract a minimal test case that can be added to the test-suite 🏃
|
1 similar comment
🔴 CI failure at commit f2ad35d without any failure in the test-suite ✔️ Corresponding job for the base commit f9c9ee5 succeeded ❔ Ask me to try to extract a minimal test case that can be added to the test-suite 🏃
|
fiat failure seems unrelated. I can't say about analysis. |
🔴 CI failure at commit f2ad35d without any failure in the test-suite ✔️ Corresponding job for the base commit f9c9ee5 succeeded ❔ Ask me to try to extract a minimal test case that can be added to the test-suite 🏃
|
The syntax conflates the two declarations, but then the code paths are different and there are checks to ensure only meaningful options/attributes are passed.
CI was green but for fiat which is fixed in master, so I did rebase to get a fully green CI. |
@SkySkimmer would you mind taking care of this? I'd like to first merge this elpi overlay, and then prepare the one for #15946 |
@ejgallego is still assigned though |
@SkySkimmer I think it is OK to take over in this case. The assignment was a month ago, so I don't think we can reasonably expect it to be looked at. |
Last activity was just before holidays though |
I think @ejgallego was OK with the PR both in principle and with the current code, I did only add a few comments after his review. |
I am not sure why, my last activity was 11 days ago, then I went on holidays [and I did a review but the PR was not ready, so really I could only have reacted on the weekend] . So yes, the assignement date is one month, but how it is relevant? That being said, the PR looks good to me, so go ahead and take over. A think to keep in mind tho is the conflict with #15877 , that one I did have a look but I didn't manage to understand the code. I'd suggest pinging @proux01 in case he'd like to comment anything about this one. |
If you are back from VAC you can also merge it yourself. I'd like to merge overlay, since I then have to make another one which will generate conflicts, so a quick merge would be appreciated |
@coqbot merge now |
@SkySkimmer: Please take care of the following overlays:
|
thanks |
In the context of Elpi I want to let coq elaborate an inductive declaration (up to the constr level) without necessarily adding it to the environment, the same for records and context.
This PR exports the first half of do_mutual_inductive (the part which is side effect free) and do_record and do_context.
Fixes #14737
TODO: