Skip to content

[ci] bump elpi (goodbye camlp5, hello menhir) #15948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 28, 2022

Conversation

gares
Copy link
Member

@gares gares commented Apr 26, 2022

Elpi 1.15.x does not depend on camlp5. This should make it easier to test recent ocaml compilers in CI

Overlay PR:

@gares gares requested a review from a team as a code owner April 26, 2022 08:41
@gares gares added the needs: overlay This is breaking external developments we track in CI. label Apr 26, 2022
@gares gares added this to the 8.16+rc1 milestone Apr 26, 2022
@SkySkimmer SkySkimmer self-assigned this Apr 26, 2022
@ppedrot
Copy link
Member

ppedrot commented Apr 26, 2022

The change to the docker image will conflict with #15947. Who goes first?

@gares
Copy link
Member Author

gares commented Apr 26, 2022

I still have to prepare the overlay for elpi. If yours is ready, please merge it now.

@coqbot-app
Copy link
Contributor

coqbot-app bot commented Apr 27, 2022

🔴 CI failures at commit bd22f42 without any failure in the test-suite

✔️ Corresponding jobs for the base commit fe711c0 succeeded

❔ Ask me to try to extract minimal test cases that can be added to the test-suite

🏃 @coqbot ci minimize will minimize the following targets: ci-elpi, ci-fiat_crypto, ci-vst
  • You can also pass me a specific list of targets to minimize as arguments.

@gares
Copy link
Member Author

gares commented Apr 28, 2022

ci-elpi is green!

@gares
Copy link
Member Author

gares commented Apr 28, 2022

@SkySkimmer can I have this one merged quickly so that I can rebase the overlay for HB (for #15693) on top of this one and have the CI of #15693 green as well? (I broke HB in #15872)

@ppedrot ppedrot added kind: infrastructure CI, build tools, development tools. and removed needs: overlay This is breaking external developments we track in CI. labels Apr 28, 2022
@SkySkimmer
Copy link
Contributor

@coqbot merge now

@coqbot-app coqbot-app bot merged commit db1a937 into rocq-prover:master Apr 28, 2022
@coqbot-app
Copy link
Contributor

coqbot-app bot commented Apr 28, 2022

@SkySkimmer: Please take care of the following overlays:

  • 15948-gares-bump-elpi.sh

@gares gares deleted the bump-elpi branch April 28, 2022 11:57
gares added a commit to math-comp/hierarchy-builder that referenced this pull request Apr 28, 2022
@gares
Copy link
Member Author

gares commented Apr 28, 2022

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: infrastructure CI, build tools, development tools.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants