Skip to content

feat(containers): add VPC integration feature flag #4736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
May 19, 2025
Merged

feat(containers): add VPC integration feature flag #4736

merged 11 commits into from
May 19, 2025

Conversation

scaleway-bot
Copy link
Contributor

No description provided.

@scaleway-bot scaleway-bot requested review from a team and remyleone as code owners May 16, 2025 15:04
@github-actions github-actions bot added vpc Virtual Private Cloud (VPC) issues, bugs and feature requests container Container issues, bugs and feature requests labels May 16, 2025
@github-actions github-actions bot removed the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label May 16, 2025
@github-actions github-actions bot added the vpc Virtual Private Cloud (VPC) issues, bugs and feature requests label May 19, 2025
jremy42
jremy42 previously approved these changes May 19, 2025
View reviewed changes
@jremy42 jremy42 dismissed their stale review May 19, 2025 08:39

pipeline failed

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.09%. Comparing base (5bf53e0) to head (13d32a8).
Report is 630 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (13d32a8). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (13d32a8)
2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #4736       +/-   ##
===========================================
- Coverage   75.45%   55.09%   -20.36%     
===========================================
  Files         202      312      +110     
  Lines       44323    79739    +35416     
===========================================
+ Hits        33444    43933    +10489     
- Misses       9653    34398    +24745     
- Partials     1226     1408      +182

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yfodil yfodil added this pull request to the merge queue May 19, 2025
Merged via the queue into scaleway:master with commit 61e2fa4 May 19, 2025
14 checks passed
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request May 26, 2025
@scaleway-bot @remyleone
@yfodil @Laure-di
feat(containers): add VPC integration feature flag (scaleway#4736)
9327d53 
Co-authored-by: Rémy Léone <[email protected]>
Co-authored-by: Yacine FODIL <[email protected]>
Co-authored-by: Yacine Fodil <[email protected]>
@BrewTestBot BrewTestBot mentioned this pull request Jun 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yfodil yfodil yfodil approved these changes

@jremy42 jremy42 jremy42 left review comments

@remyleone remyleone Awaiting requested review from remyleone remyleone is a code owner

Assignees
No one assigned
Labels
container Container issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scaleway-bot @codecov-commenter @jremy42 @yfodil @remyleone