Skip to content

feat(containers): add VPC integration feature flag #4736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 19, 2025
Merged

feat(containers): add VPC integration feature flag #4736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
73098e1
feat: update generated APIs
scaleway-bot May 16, 2025
4ee1aaf
Fix
remyleone May 16, 2025
e9b7a60
Fix
remyleone May 16, 2025
c552230
Fix
remyleone May 16, 2025
790a36d
Fix
remyleone May 19, 2025
acaef97
Fix
remyleone May 19, 2025
5c3bdda
Fix
remyleone May 19, 2025
ec5e4ae
Fix
remyleone May 19, 2025
60c2af5
test
yfodil May 19, 2025
c2a8b65
fix
yfodil May 19, 2025
13d32a8
Merge branch 'master' into v1.6538.0
yfodil May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-container-container-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ ARGS:
[health-check.failure-threshold] Number of consecutive health check failures before considering the container unhealthy.
[health-check.interval] Period between health checks.
[tags.{index}] Tags of the Serverless Container
[private-network-id]
[deploy=true] Deploy container after creation
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

Expand Down
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-container-container-update-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ ARGS:
[health-check.failure-threshold] Number of consecutive health check failures before considering the container unhealthy.
[health-check.interval] Period between health checks.
[tags.{index}] Tags of the Serverless Container
[private-network-id]
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

DEPRECATED ARGS:
Expand Down
1 change: 1 addition & 0 deletions cmd/scw/testdata/test-all-usage-container-namespace-create-usage.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ ARGS:
[secret-environment-variables.{index}.key]
[secret-environment-variables.{index}.value]
[tags.{index}] Tags of the Serverless Container Namespace
[activate-vpc-integration]
[region=fr-par] Region to target. If none is passed will use default region from the config (fr-par | nl-ams | pl-waw)

FLAGS:
Expand Down
3 changes: 3 additions & 0 deletions docs/commands/container.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ scw container container create [arg=value ...]
| health-check.failure-threshold | | Number of consecutive health check failures before considering the container unhealthy. |
| health-check.interval | | Period between health checks. |
| tags.{index} | | Tags of the Serverless Container |
| private-network-id | | |
| deploy | Default: `true` | Deploy container after creation |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |

Expand Down Expand Up @@ -216,6 +217,7 @@ scw container container update <container-id ...> [arg=value ...]
| health-check.failure-threshold | | Number of consecutive health check failures before considering the container unhealthy. |
| health-check.interval | | Period between health checks. |
| tags.{index} | | Tags of the Serverless Container |
| private-network-id | | |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down Expand Up @@ -477,6 +479,7 @@ scw container namespace create [arg=value ...]
| secret-environment-variables.{index}.key | | |
| secret-environment-variables.{index}.value | | |
| tags.{index} | | Tags of the Serverless Container Namespace |
| activate-vpc-integration | | |
| region | Default: `fr-par`<br />One of: `fr-par`, `nl-ams`, `pl-waw` | Region to target. If none is passed will use default region from the config |


Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ require (
github.com/mattn/go-isatty v0.0.20
github.com/moby/buildkit v0.13.2
github.com/opencontainers/go-digest v1.0.0
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.33.0.20250513115908-b0f902104f82
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.33.0.20250516160029-3f13aad4f58a
github.com/skratchdot/open-golang v0.0.0-20200116055534-eef842397966
github.com/spf13/cobra v1.9.1
github.com/spf13/pflag v1.0.6
Expand Down
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,8 +466,8 @@ github.com/rogpeppe/go-internal v1.11.0/go.mod h1:ddIwULY96R17DhadqLgMfk9H9tvdUz
github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06 h1:OkMGxebDjyw0ULyrTYWeN0UNCCkmCWfjPnIA2W6oviI=
github.com/sabhiram/go-gitignore v0.0.0-20210923224102-525f6e181f06/go.mod h1:+ePHsJ1keEjQtpvf9HHw0f4ZeJ0TLRsxhunSI2hYJSs=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.33.0.20250513115908-b0f902104f82 h1:HiThszq4WsYeLYznJjVm0RlsBw5uRalTPp3YEl5b0sc=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.33.0.20250513115908-b0f902104f82/go.mod h1:qiGzapFyNPFwBBLJ+hTFykKSnU95n1zL64+o1ubmwf0=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.33.0.20250516160029-3f13aad4f58a h1:nqYV4PtTnMTGYqUe3mQI7qm26QxcO/Jy/pA5qCOgfH0=
github.com/scaleway/scaleway-sdk-go v1.0.0-beta.33.0.20250516160029-3f13aad4f58a/go.mod h1:qiGzapFyNPFwBBLJ+hTFykKSnU95n1zL64+o1ubmwf0=
github.com/sclevine/spec v1.4.0 h1:z/Q9idDcay5m5irkZ28M7PtQM4aOISzOpj4bUPkDee8=
github.com/sclevine/spec v1.4.0/go.mod h1:LvpgJaFyvQzRvc1kaDs0bulYwzC70PbiYjC4QnFHkOM=
github.com/secure-systems-lab/go-securesystemslib v0.8.0 h1:mr5An6X45Kb2nddcFlbmfHkLguCE9laoZCUzEEpIZXA=
Expand Down
18 changes: 18 additions & 0 deletions internal/namespaces/container/v1beta1/container_cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,12 @@ func containerNamespaceCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "activate-vpc-integration",
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(
scw.RegionFrPar,
scw.RegionNlAms,
Expand Down Expand Up @@ -715,6 +721,12 @@ func containerContainerCreate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "private-network-id",
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(
scw.RegionFrPar,
scw.RegionNlAms,
Expand Down Expand Up @@ -937,6 +949,12 @@ func containerContainerUpdate() *core.Command {
Deprecated: false,
Positional: false,
},
{
Name: "private-network-id",
Required: false,
Deprecated: false,
Positional: false,
},
core.RegionArgSpec(
scw.RegionFrPar,
scw.RegionNlAms,
Expand Down
Loading
Loading