Enlarge bounding box by the largest stroke width. #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
What Github issue does this resolve (please include link)?
Fixes #175
Proposed Changes
Describe what this Pull Request does
Enlarge the bounding box that is read from the DOM method
getBBox()
which doesn't take into account the strokes by the largest found stroke width. As mentioned in the code comment, this may have false positives, as in it may enlarge an SVG viewbox that didn't need it (if, for example, the largest shape was a fill, not a stroke). But it will always make the viewbox large enough to include the strokes, which seems like an ok trade-off.Reason for Changes
Explain why these changes should be made
Clipping of SVG's, which is impacting project rendering and also messes with the upcoming speech bubble rendering.
Test Coverage
Please show how you have added tests to cover your changes
None.
/cc @tmickel since it looks like a lot of this code was yours.