-
Notifications
You must be signed in to change notification settings - Fork 25
Changed BASE_URL for API calls to reflect working URL and upgraded #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Is someone planning to review this? |
|
Like the update, but probably worth a few changes. Left comments. |
andrewelkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the .idea/* files.
Keep the setup file with singer-io
| description='Singer.io tap for extracting currency exchange rate data from the exchangeratesapi.io API', | ||
| author='Stitch', | ||
| url='http://github.com/singer-io/tap-exchangeratesapi', | ||
| url='http://github.com/adswerve/tap-exchangeratesapi', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth reverting this change.
Description of change
Updated base_url variable which is used in all http requests. The previous one no longer worked.
Manual QA steps
NOTE: Any historical date larger than Y2K works in the above examples
Risks
Rollback steps