Skip to content

Conversation

@iamnutzy1975
Copy link

Description of change

Updated base_url variable which is used in all http requests. The previous one no longer worked.

Manual QA steps

Risks

Rollback steps

  • revert this branch

@iamnutzy1975
Copy link
Author

Is someone planning to review this?

@andrewelkins
Copy link

andrewelkins commented Apr 13, 2023

Like the update, but probably worth a few changes. Left comments.

Copy link

@andrewelkins andrewelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the .idea/* files.
Keep the setup file with singer-io

description='Singer.io tap for extracting currency exchange rate data from the exchangeratesapi.io API',
author='Stitch',
url='http://github.com/singer-io/tap-exchangeratesapi',
url='http://github.com/adswerve/tap-exchangeratesapi',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth reverting this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants