-
Notifications
You must be signed in to change notification settings - Fork 25
Changed BASE_URL for API calls to reflect working URL and upgraded #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 10 commits
43d1e2f
c192f4a
b747d3c
dc1e54d
e86ad36
d6e730c
8fee9dc
9db9572
7750da1
af7386f
00fcab6
3f5500c
ec945e5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
| # Description of change | ||
| (write a short description or paste a link to JIRA) | ||
| Updated base_url variable which is used in all http requests. The previous one no longer worked. | ||
|
|
||
| # Manual QA steps | ||
| - | ||
| - Use Postman to try the previous HTTP request: https://api.exchangeratesapi.io/2022-03-03?base=USD | ||
| - Use Postman to try the current (working) HTTP request: https://api.apilayer.com/exchangerates_data/2022-03-03?base=USD | ||
| NOTE: Any historical date larger than Y2K works in the above examples | ||
|
|
||
| # Risks | ||
| - | ||
| - base URL now includes a level 1 path. Not the best practice per se, but as long as every supported endpoint includes that full base URL + level 1 path, the risk is mitigated. That holds true when checking the endpoint documentation located here https://apilayer.com/marketplace/exchangerates_data-api#endpoints | ||
|
|
||
| # Rollback steps | ||
| - revert this branch | ||
| - revert this branch |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| { | ||
| "base": "AUD", | ||
| "start_date": "2017-02-02" | ||
| "start_date": "2017-02-02", | ||
| "apikey": "VzNBD8lZ5lVkVinRFgM7xM3bf77wAyHn" | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth reverting this change.