plugin: add migration step to configuration #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
reviewed
Jun 26, 2023
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
Nits. As usual.
Feels like I should test this "in prod", maybe with the os.remove() commented out at first. 😅
Exirel
commented
Jun 26, 2023
Exirel
commented
Jun 26, 2023
dgw
reviewed
Jun 29, 2023
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
I know this suggestion is going to affect tests, too, but I figured you should have a chance to reject the overall idea before either of us spends time reworking them. 😉
4 tasks
dgw
approved these changes
Jul 3, 2023
With the help of dgw. Co-authored-by: dgw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tin.
The migration is performed when running
sopel-plugin configure remindand confirming the migration. I had to adapt the tests to use a different monkeypatch approach, and it worked quite well in the end.