remind: remove plugin reimplemented as external package w/better tests #2478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
the
Breaking Change
Contributor
|
Sopel Remind is now available as a package version 0.1.0! |
4 tasks
Member
Author
|
Just need sopel-irc/sopel-remind#5 to be released and we're set to ship this. I take full responsibility for it not being merged yet, because I'm still making suggestions over there to this day. 😅 (I probably should've left |
Member
Author
|
Migration feature is released upstream! Time to ready this. |
Contributor
|
And it's done! sopel-remind 0.2.0 is up and allows bot's owner to migrate from the built-in plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin. Development moved to https://github.com/sopel-irc/sopel-remind, with more comprehensive tests and support for running the plugin on Python 3.11+.(built-in has a regex pattern error).
Starting as a draft because of impending merge conflict from #2471 and waiting for a migration path for existing reminders to the new plugin (see sopel-irc/sopel-remind#1).
Checklist
make qa(runsmake qualityandmake test)remindis no longer included with the base Sopel installation, and the test suite was correctly removed (no leftovers causing failures post-deletion)