mypy: use generic types instead of typing aliases where possible
#2480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
approved these changes
Jun 27, 2023
Contributor
Exirel
left a comment
Exirel
left a comment
There was a problem hiding this comment.
If mypy doesn't complain, I'm OK with that.
SnoopJ
approved these changes
Jun 27, 2023
Contributor
SnoopJ
left a comment
SnoopJ
left a comment
There was a problem hiding this comment.
LGTM. I had forgotten that typing.Iterable, typing.Generator were deprecated and I'm annoyed that collections.abc is the "right" way to do it, but that's hardly this PR's fault, and using the generic forms of the built-ins is a huge win.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out that "where possible" is equivalent to "almost everywhere". There are a very few places where we still have to leave
typingaliases in for compatibility with Python versions before 3.9.Checklist
make qa(runsmake qualityandmake test)mypy1.4 under Python 3.8, to make sure none of the changes breaks that version. (I did not bother to test Python 3.7 since it's EOL any day now. Tentatively it's EOL today, but I haven't seen any formal announcement or update to the Python Versions page yet.)Notes
Follow-up to #2471; prerequisite for finishing #2477 (so I can extract a very nice, clean file for packaging externally).
Haven't touched
remindas it's due to be removed shortly (#2478, replaced by external package).