translate: catch requests exceptions #2153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
added
the
Bugfix
Exirel
force-pushed
the
translate-error-handling
branch
from
07cb535 to
12af23d
Compare
Exirel
force-pushed
the
translate-error-handling
branch
from
12af23d to
a5d4928
Compare
dgw
approved these changes
Jul 10, 2021
Member
dgw
left a comment
dgw
left a comment
There was a problem hiding this comment.
On the one hand, requests.exceptions.Timeout could be handled by the same except block as its parent class requests.exceptions.RequestException. But it's not bad to handle it separately and put more info in the error sent to IRC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin (fix #2152).
Also I added some logging, because why not.
Checklist
make qa(runsmake qualityandmake test)