-
-
Notifications
You must be signed in to change notification settings - Fork 409
docs: about time for plugins #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set the 8.0 milestone as a goal. 😁
I'm a little bit 🤔 about putting this in plugin/bot.rst, but there isn't really a better place other than shoehorning it into api.rst before the automodule docs for tools.time.
And maybe we could split
What do you think? If you agree, I'd suggest to ship this PR, then split in a future PR. |
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick mode engaged, again… Are you tired of me yet? 🙉
I do indeed like the idea of making the bot-related docs a bit more digestible by splitting them into separate pages, and I also agree that that's best left for a future patch.
Note I'm only submitting this as "Request changes" because apparently I didn't submit the previous review as such, and I want this PR to show a clear status in the list—i.e. not look like it's unreviewed.
dgw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it. Instead of putting a ring on it, I'll just ask you to make LGTM happy. 😁
As per usual, with dgw's edits. Co-authored-by: dgw <[email protected]>
3e2b97f to
28080ac
Compare
This is a joke: LGTM is now happy. |
Of course it was a joke, lol. LGTM was only complaining because it "can't" analyze PRs with merge conflicts. 🤷♂️ |
Description
This is a first attempt at a documentation about time management for Plugin author. I think way more could be written, yet it will do for now. I don't want to have something blocked in a perpetual draft state because "it could be better". Of course it can be better, and it'll be. In future PRs.
Checklist
make qa(runsmake qualityandmake test)