search: consistently warn about excessive "site:" operators if no results #2254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parity with DuckDuckGo behavior, since both search engines can return weird (or no) results if too many such operators are combined.
Just seems best to be consistent across all commands.
Exirel
approved these changes
Feb 16, 2022
dgw
added a commit
that referenced
this pull request
Feb 16, 2022
search: consistently warn about excessive "site:" operators if no results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This applies the warning from #1418 (intended to help users avoid weird behavior as described in #1415) to all search queries that contain multiple
site:operators and return no result, regardless of which search engine is used.For the combo
.searchcommand that uses both Bing and DDG, the warning triggers only if both engines return nothing.I will finally declare #1415 closed after this patch, as we've done all we can do about it from the client end.
Checklist
make qa(runsmake qualityandmake test)