Skip to content

search: consistently warn about excessive "site:" operators if no results #2254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dgw merged 2 commits into from
Feb 16, 2022
Merged

search: consistently warn about excessive "site:" operators if no results #2254

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82387d8
search: warn about excessive "site:" operators if no Bing result found
dgw Feb 12, 2022
7791f18
search: warn for no results w/multiple "site:" operators in combo search
dgw Feb 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions sopel/modules/search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,12 @@ def bing(bot, trigger):
if result:
bot.say(result)
else:
bot.reply("No results found for '%s'." % query)
msg = "No results found for '%s'." % query
if query.count('site:') >= 2:
# This check exists because of issue #1415. The git.io link will take the user there.
# (Better a sopel.chat link, but it's not set up to do that. This is shorter anyway.)
msg += " Try again with at most one 'site:' operator. See https://git.io/fpKtP for why."
bot.reply(msg)


@plugin.command('search')
Expand All @@ -149,7 +154,15 @@ def search(bot, trigger):
bu = bing_search(query) or '-'
du = duck_search(query) or '-'

if bu == du:
if bu == '-' and du == '-':
msg = "No results found for '%s'." % query
if query.count('site:') >= 2:
# This check exists because of issue #1415. The git.io link will take the user there.
# (Better a sopel.chat link, but it's not set up to do that. This is shorter anyway.)
msg += " Try again with at most one 'site:' operator. See https://git.io/fpKtP for why."
bot.reply(msg)
return
elif bu == du:
result = '%s (b, d)' % bu
else:
if len(bu) > 150:
Expand Down