Skip to content

Conversation

@dgw
Copy link
Member

@dgw dgw commented Nov 29, 2023

Description

After I closed #2395 there was some question whether the FAQ added in #2533 actually covered everything that was requested.

Deciding that we could always do it better, @SnoopJ convinced me (it wasn't hard) to add more info about logs to the FAQ.

I also clarified a piece of the "Logging" section docs under "The [core] configuration section" because it confused me, too.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches

There is always a log format and a log date format because those options
in the core section have defaults. Likewise, the default logging level
of INFO exists even if not set explicitly by the config file.

(Removed the confusing bit about WARNING being the default; that's the
default of the `level` argument to `logging.basicConfig()`, but Sopel
always passes the value of its `logging_level` setting.)
@dgw dgw added this to the 8.0.0 milestone Nov 29, 2023
@dgw dgw requested a review from a team November 29, 2023 18:35
Copy link
Contributor

@SnoopJ SnoopJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a good sport, thank you for tackling this one!

Modulo my one remark about more cleanly separating "do this when filing a report" from more thorough information about raw logs, this LGTM.

Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpicking, aside from that, great idea!

@dgw dgw requested review from Exirel and SnoopJ November 29, 2023 22:13
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still think this is too verbose and would be better with less compact paragraphs. However, I don't have the proper wording/phrasing in mind, and it's better to have all that information in the FAQ now than wait another month to get the "best" version.

That will do, and I'm happy about it!

dgw added 2 commits November 29, 2023 16:41
It is relative to the config's `homedir`, which is the config's parent
folder by default but can be changed.

While I was here: Added a note indicating why one might want to change
the `homedir` setting, for example to match service-unit conventions.
@dgw
Copy link
Member Author

dgw commented Nov 29, 2023

I should note that merging this should come with a follow-up PR (draft) updating the relevant issue template(s) to link to this entry from the "Relevant logs" field description. Assuming links are allowed there, that is. I haven't checked into that yet.

@dgw dgw merged commit 7be94c3 into master Nov 30, 2023
@dgw dgw deleted the faq-logs branch November 30, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: include how-to information for getting help/reporting bugs

4 participants