Skip to content

feat: update publish-image action to fix RELEASE arg #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

dervoeti
Copy link
Member

@dervoeti dervoeti commented Jun 26, 2025

Description

With image-tools 0.0.17 we now have a separate argument to provide the SDP version. This is needed because we want to include the architecture in the image tag (0.0.0-dev-amd64) but not in the RELEASE argument (that one should just be 0.0.0-dev or 25.7.0).
Before 0.0.17 the --image-version argument was used for both the image tag and the RELEASE arg.

This PR bumps the Github actions to use the new version of image-tools and provide the SDP version as a separate --release argument so RELEASE does not contain the architecture anymore.

See stackabletech/actions#47 and stackabletech/image-tools#55

Successful build with the new action: https://github.com/stackabletech/docker-images/actions/runs/15897788169/job/44833458187

I also checked the release label for the new image:

# Old
docker inspect oci.stackable.tech/sdp/zookeeper:3.9.2-stackable0.0.0-dev-arm64 | rg release
"release": "0.0.0-dev-arm64",

# New
docker inspect oci.stackable.tech/sdp/zookeeper:3.9.3-stackable0.0.0-dev-arm64 | rg release
"release": "0.0.0-dev",

Definition of Done Checklist

Note

Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.

Please make sure all these things are done and tick the boxes

  • Changes are OpenShift compatible
  • All added packages (via microdnf or otherwise) have a comment on why they are added
  • Things not downloaded from Red Hat repositories should be mirrored in the Stackable repository and downloaded from there
  • All packages should have (if available) signatures/hashes verified
  • Add an entry to the CHANGELOG.md file
  • Integration tests ran successfully
TIP: Running integration tests with a new product image

The image can be built and uploaded to the kind cluster with the following commands:

bake --product <product> --image-version <stackable-image-version>
kind load docker-image <image-tagged-with-the-major-version> --name=<name-of-your-test-cluster>

See the output of bake to retrieve the image tag for <image-tagged-with-the-major-version>.

@dervoeti dervoeti requested a review from razvan June 26, 2025 09:32
@dervoeti dervoeti self-assigned this Jun 26, 2025
@dervoeti dervoeti moved this to Development: Waiting for Review in Stackable Engineering Jun 26, 2025
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dervoeti dervoeti added this pull request to the merge queue Jun 26, 2025
Merged via the queue into main with commit 5485644 Jun 26, 2025
9 of 19 checks passed
@dervoeti dervoeti deleted the feat/release-arg-sdp-version branch June 26, 2025 09:37
@dervoeti dervoeti moved this from Development: Waiting for Review to Development: Done in Stackable Engineering Jun 27, 2025
@lfrancke lfrancke moved this from Development: Done to Done in Stackable Engineering Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants