feat: update publish-image action to fix RELEASE arg #1188
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With
image-tools
0.0.17 we now have a separate argument to provide the SDP version. This is needed because we want to include the architecture in the image tag (0.0.0-dev-amd64
) but not in theRELEASE
argument (that one should just be0.0.0-dev
or25.7.0
).Before 0.0.17 the
--image-version
argument was used for both the image tag and theRELEASE
arg.This PR bumps the Github actions to use the new version of
image-tools
and provide the SDP version as a separate--release
argument soRELEASE
does not contain the architecture anymore.See stackabletech/actions#47 and stackabletech/image-tools#55
Successful build with the new action: https://github.com/stackabletech/docker-images/actions/runs/15897788169/job/44833458187
I also checked the release label for the new image:
Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
bake
to retrieve the image tag for<image-tagged-with-the-major-version>
.