Skip to content

feat: separate --release argument for SDP version #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2025

Conversation

dervoeti
Copy link
Member

@dervoeti dervoeti commented Jun 25, 2025

As discussed, we need a separate argument for the SDP version because we want to include the architecture in the image tag (0.0.0-dev-amd64) but not in the RELEASE argument.

I tested the change by replacing the Zookeeper Dockerfile with this:

FROM stackable/image/java-base

ARG RELEASE
RUN <<EOF
echo "RELEASE: ${RELEASE}"
sleep 5
EOF

And then ran a few tests:

bake -p zookeeper=3.9.3 -i 0.0.0-dev-amd64
bake -p zookeeper=3.9.3 -i 0.0.0-dev-amd64 --release 0.0.0-dev
bake -p zookeeper=3.9.3 -i 0.0.0-dev-amd64 --release 0.0.0-dev-bar
bake -p zookeeper=3.9.3 -i 0.0.0-dev-amd64 --release 25.3.0
bake -p zookeeper=3.9.3 -i 0.0.0-dev-amd64 --release 25.3.0-foo
bake -p zookeeper=3.9.3 -i 0.0.0-dev-amd64 --release 25.3.0-rc13
bake -p zookeeper=3.9.3 -i 0.0.0-dev-amd64 --release 25.3.0-amd64

@dervoeti dervoeti requested a review from razvan June 25, 2025 13:33
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see suggestions

dervoeti and others added 3 commits June 25, 2025 15:53
Copy link
Member

@razvan razvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@dervoeti dervoeti added this pull request to the merge queue Jun 25, 2025
Merged via the queue into main with commit e7bb02f Jun 25, 2025
4 checks passed
@dervoeti dervoeti deleted the feat/separate-release-arg branch June 25, 2025 14:15
@dervoeti dervoeti self-assigned this Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants