Skip to content

Update Styled Components to V6 #1695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Apr 30, 2024
Merged

Update Styled Components to V6 #1695

merged 9 commits into from
Apr 30, 2024

Conversation

christiancp100
Copy link
Contributor

@christiancp100 christiancp100 commented Apr 18, 2024 •
edited by joshuaellis
Loading

What does it do?

  • Updates styled-components peer dep & local dep from v5 to v6
  • Changes Box/Grid/Flex & Typography to react components over styled-components
  • Disallow use of as and instead use the tag prop to change underlying DOM element
  • Default color of Typography is currentColor similar to SVGs

Why is it needed?

  • Keep the design-system dependencies updated
  • Integrate inbuilt type system from styled-components

Related issue(s)/PR(s)

  • resolves DX-1188

@christiancp100 christiancp100 added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: dependencies relates to dependencies within the repo labels Apr 18, 2024
@christiancp100 christiancp100 self-assigned this Apr 18, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2a0e15f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@strapi/design-system Major
@strapi/icons Major
@strapi/ui-primitives Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design_system_v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 9:01am
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 9:01am
design-system-website ❌ Failed (Inspect) Apr 29, 2024 9:01am

@christiancp100 christiancp100 changed the base branch from develop to releases/2.0.0 April 18, 2024 13:00
@github-actions GitHub Actions

This comment was marked as spam.

Sign in to view
joshuaellis
joshuaellis reviewed Apr 18, 2024
View reviewed changes
@joshuaellis joshuaellis force-pushed the chore/prefix-styled-components-props branch from 408471b to 7de92e6 Compare April 19, 2024 07:26
@joshuaellis

This comment was marked as outdated.

Sign in to view
@christiancp100 christiancp100 mentioned this pull request Apr 24, 2024
Closed
@vercel vercel bot temporarily deployed to Preview – design-system April 24, 2024 13:32 Inactive
@joshuaellis joshuaellis force-pushed the chore/prefix-styled-components-props branch 3 times, most recently from 7aecd55 to bc114bd Compare April 25, 2024 10:18
@joshuaellis joshuaellis force-pushed the chore/prefix-styled-components-props branch from 5190769 to fc1e69b Compare April 28, 2024 20:21
@joshuaellis joshuaellis marked this pull request as ready for review April 29, 2024 07:07
@joshuaellis joshuaellis force-pushed the chore/prefix-styled-components-props branch from 4ca9b6c to 982d9fd Compare April 29, 2024 08:48
@joshuaellis joshuaellis force-pushed the chore/prefix-styled-components-props branch from 982d9fd to 2a0e15f Compare April 29, 2024 08:58
@joshuaellis
Copy link
Contributor

Okay I think this is good to go, to solve a lot of the issues we had around how as and forwardAs behaves, i've just made the tag prop, also benefit is it's not tied to the styling library should we choose to change in the future.

@joshuaellis joshuaellis merged commit 649d0f5 into releases/2.0.0 Apr 30, 2024
@joshuaellis joshuaellis deleted the chore/prefix-styled-components-props branch April 30, 2024 06:53
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Merged
@joshuaellis joshuaellis linked an issue Apr 30, 2024 that may be closed by this pull request
[bug]: Components using as prop do not have said prop's components inferred #1401
Closed
@joshuaellis joshuaellis added the flag: 💥 Breaking change This PR contains breaking changes and should not be merged label May 1, 2024
@joshuaellis joshuaellis linked an issue May 7, 2024 that may be closed by this pull request
[chore]: Stop using shouldForwardProp and just use $ for simplicity #917
Closed
This was referenced May 9, 2024
Closed
Closed
@alexandrebodin alexandrebodin mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

@jhoward1994 jhoward1994 Awaiting requested review from jhoward1994

@madhurisandbhor madhurisandbhor Awaiting requested review from madhurisandbhor

Assignees

@christiancp100 christiancp100

Labels
flag: 💥 Breaking change This PR contains breaking changes and should not be merged pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: dependencies relates to dependencies within the repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug]: Components using as prop do not have said prop's components inferred [chore]: Stop using shouldForwardProp and just use $ for simplicity
2 participants
@christiancp100 @joshuaellis