Skip to content

Add transient props to Box, Flex and Typography #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

christiancp100
Copy link
Contributor

@christiancp100 christiancp100 commented Apr 24, 2024

What does it do?

It sets the transient props of Box, Flex and Typography components.

Why is it needed?

To avoid having non DOM props in the DOM.

How to test it?

Check that everything still works the same way and that there are no errors regarding non DOM props in the browser console

Related issue(s)/PR(s)

#1695

@christiancp100 christiancp100 added pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: dependencies relates to dependencies within the repo labels Apr 24, 2024
@christiancp100 christiancp100 self-assigned this Apr 24, 2024
Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: fba94e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Apr 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
design-system ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 6:40am
design-system-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2024 6:40am

Copy link
Contributor

Size Change: +320 B (0%)

Total Size: 490 kB

Filename Size Change
packages/strapi-design-system/dist/index.js 196 kB +156 B (0%)
packages/strapi-design-system/dist/index.mjs 194 kB +164 B (0%)
ℹ️ View Unchanged
Filename Size
packages/primitives/dist/index.js 16.6 kB
packages/primitives/dist/index.mjs 16.1 kB
packages/strapi-icons/dist/index.js 22.1 kB
packages/strapi-icons/dist/index.mjs 21.7 kB
packages/strapi-icons/dist/symbols-index.js 12 kB
packages/strapi-icons/dist/symbols-index.mjs 11.9 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: chore This PR contains chore tasks (cleanups, configs, tooling...) source: dependencies relates to dependencies within the repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants