Skip to content

fix: set z-index on Label to avoid z-index breaking out of parent #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2022

Conversation

joshuaellis
Copy link
Contributor

What does it do?

Set z-index to 0 on the Label of ToggleCheckbox.

Why is it needed?

it's absolute children break out of the parent currently and will therefore show on top of popovers

Related issue(s)/PR(s)

CONTENT-572

@joshuaellis joshuaellis added pr: fix This PR is fixing a bug source: design-system relates to design-system package labels Oct 11, 2022
@joshuaellis joshuaellis added this to the 1.2.6 milestone Oct 11, 2022
@vercel
Copy link

vercel bot commented Oct 11, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
design-system ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 9:05AM (UTC)
design-system-website ✅ Ready (Inspect) Visit Preview Oct 11, 2022 at 9:05AM (UTC)

Copy link
Contributor

@ronronscelestes ronronscelestes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch thank you for the fix 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: fix This PR is fixing a bug source: design-system relates to design-system package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants