Skip to content

fix: set z-index on Label to avoid z-index breaking out of parent #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2022
Merged

fix: set z-index on Label to avoid z-index breaking out of parent #717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8766f47
fix: set z-index on Label to avoid z-index breaking out of parent
joshuaellis Oct 11, 2022
402d3f3
chore: update snapshots
joshuaellis Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/strapi-design-system/src/ToggleCheckbox/ToggleCheckbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { Flex } from '../Flex';
const Label = styled.label`
position: relative;
display: inline-block;
z-index: 0;
`;

const ToggleCheckboxWrapper = styled(Box)`
Expand Down
10 changes: 10 additions & 0 deletions packages/strapi-design-system/tests/__snapshots__/storyshots.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49721,6 +49721,7 @@ exports[`Storyshots Design System/Components/ToggleCheckbox base 1`] = `
.c3 {
position: relative;
display: inline-block;
z-index: 0;
}

.c5 {
Expand Down Expand Up @@ -49897,6 +49898,7 @@ exports[`Storyshots Design System/Components/ToggleCheckbox disabled 1`] = `
.c3 {
position: relative;
display: inline-block;
z-index: 0;
}

.c5 {
Expand Down Expand Up @@ -50078,6 +50080,7 @@ exports[`Storyshots Design System/Components/ToggleCheckbox null-value 1`] = `
.c3 {
position: relative;
display: inline-block;
z-index: 0;
}

.c5 {
Expand Down Expand Up @@ -50251,6 +50254,7 @@ exports[`Storyshots Design System/Components/ToggleCheckbox size S 1`] = `
.c3 {
position: relative;
display: inline-block;
z-index: 0;
}

.c5 {
Expand Down Expand Up @@ -50483,6 +50487,7 @@ exports[`Storyshots Design System/Components/ToggleInput base 1`] = `
.c10 {
position: relative;
display: inline-block;
z-index: 0;
}

.c12 {
Expand Down Expand Up @@ -50830,6 +50835,7 @@ exports[`Storyshots Design System/Components/ToggleInput clear-value 1`] = `
.c11 {
position: relative;
display: inline-block;
z-index: 0;
}

.c13 {
Expand Down Expand Up @@ -51098,6 +51104,7 @@ exports[`Storyshots Design System/Components/ToggleInput disabled 1`] = `
.c8 {
position: relative;
display: inline-block;
z-index: 0;
}

.c10 {
Expand Down Expand Up @@ -51360,6 +51367,7 @@ exports[`Storyshots Design System/Components/ToggleInput error 1`] = `
.c8 {
position: relative;
display: inline-block;
z-index: 0;
}

.c10 {
Expand Down Expand Up @@ -51610,6 +51618,7 @@ exports[`Storyshots Design System/Components/ToggleInput null-value 1`] = `
.c8 {
position: relative;
display: inline-block;
z-index: 0;
}

.c10 {
Expand Down Expand Up @@ -51856,6 +51865,7 @@ exports[`Storyshots Design System/Components/ToggleInput size S 1`] = `
.c8 {
position: relative;
display: inline-block;
z-index: 0;
}

.c10 {
Expand Down