fix: make contract and to addresses optional in webhook form #7294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
## Walkthrough
The changes update the webhook form UI by removing the required field asterisks from the "Contract Addresses" and "To Address" labels. The validation schema for the `addresses`, `fromAddresses`, and `toAddresses` fields was modified to make them optional and accept empty strings, validating only when non-empty input is provided. Additionally, the `addresses` argument passed to `useAbiMultiFetch` is now defaulted to an empty string if falsy.
## Changes
| File(s) | Change Summary |
|------------------------------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------|
| .../webhooks/components/FilterDetailsStep.tsx | Removed required field asterisks from "Contract Addresses" and "To Address" labels in the form UI. |
| .../webhooks/utils/webhookTypes.ts | Made `addresses`, `fromAddresses`, and `toAddresses` optional and allowed empty strings; validation runs only on non-empty input. Updated error messages accordingly. |
| .../webhooks/components/CreateWebhookModal.tsx | Defaulted `addresses` argument passed to `useAbiMultiFetch` to empty string if falsy to ensure a string input. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant User
participant WebhookForm
participant ValidationSchema
User->>WebhookForm: Submit form with address fields (may be empty)
WebhookForm->>ValidationSchema: Validate addresses, fromAddresses, toAddresses
alt Field is empty or undefined
ValidationSchema-->>WebhookForm: Accept as valid (no error)
else Field has input
ValidationSchema->>ValidationSchema: Check if all tokens are valid addresses
alt All tokens valid
ValidationSchema-->>WebhookForm: Accept as valid
else
ValidationSchema-->>WebhookForm: Return error (invalid addresses)
end
end
WebhookForm-->>User: Show success or error messagesPossibly related PRs
Suggested reviewers
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7294 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 909 909
Lines 58673 58673
Branches 4158 4158
=======================================
Hits 32607 32607
Misses 25959 25959
Partials 107 107
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/components/FilterDetailsStep.tsx(2 hunks)apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/utils/webhookTypes.ts(1 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/utils/webhookTypes.ts (1)
packages/thirdweb/src/exports/thirdweb.ts (1)
isAddress(308-308)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
🔇 Additional comments (4)
apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/utils/webhookTypes.ts (2)
37-50: LGTM! Validation logic correctly handles optional addresses.The validation properly allows empty values and validates addresses only when provided. The error message clearly communicates the optional nature.
60-73: LGTM! Validation logic is consistent with the addresses field.The validation properly handles optional values and maintains consistency with the
addressesfield validation pattern.apps/dashboard/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/components/FilterDetailsStep.tsx (2)
195-195: LGTM! UI correctly reflects optional field status.Removing the required asterisk properly aligns with the validation schema changes that make contract addresses optional.
285-285: LGTM! UI correctly reflects optional field status.Removing the required asterisk properly aligns with the validation schema changes that make the to address field optional.
...board/src/app/(app)/team/[team_slug]/[project_slug]/(sidebar)/webhooks/utils/webhookTypes.ts
Outdated
Show resolved
Hide resolved
size-limit report 📦
|
catalyst17
force-pushed
the
fix_make_contract_and_to_addresses_optional_in_webhook_form
branch
from
ebd415e to
da9ceef
Compare
catalyst17
force-pushed
the
fix_make_contract_and_to_addresses_optional_in_webhook_form
branch
from
da9ceef to
340a10b
Compare
catalyst17
force-pushed
the
fix_make_contract_and_to_addresses_optional_in_webhook_form
branch
from
340a10b to
a176c4d
Compare
AmineAfia
approved these changes
Jun 6, 2025
jnsdls
approved these changes
Jun 6, 2025
Merge activity
|
<!--
## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"
If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):
## Notes for the reviewer
Anything important to call out? Be sure to also clarify these in your comments.
## How to test
Unit tests, playground, etc.
-->
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on improving the handling of contract addresses in the `CreateWebhookModal` and `FilterDetailsStep` components, as well as refining validation logic for addresses in `webhookTypes.ts`. It enhances user experience by clarifying requirements and allowing optional inputs.
### Detailed summary
- In `CreateWebhookModal.tsx`, the `addresses` property now defaults to an empty string if not provided.
- In `FilterDetailsStep.tsx`, the `FormLabel` for "Contract Addresses" and "To Address" no longer includes a required indicator.
- Validation in `webhookTypes.ts` for `addresses`, `fromAddresses`, and `toAddresses` is updated to allow empty inputs and provide clearer error messages.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- **Bug Fixes**
- Removed the required field indicator from "Contract Addresses" and "To Address" labels in the form UI.
- **New Features**
- Updated form validation to allow "Contract Addresses", "From Address", and "To Address" fields to be optional and accept empty values, with improved error messages for clarity.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
graphite-app
bot
force-pushed
the
fix_make_contract_and_to_addresses_optional_in_webhook_form
branch
from
a176c4d to
62a3cd8
Compare
graphite-app
bot
deleted the
fix_make_contract_and_to_addresses_optional_in_webhook_form
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on improving the handling of contract addresses in the
CreateWebhookModalandFilterDetailsStepcomponents, as well as refining validation logic for address inputs in thewebhookTypesutility file.Detailed summary
CreateWebhookModal.tsx, changedaddressesto default to an empty string if undefined.FilterDetailsStep.tsx, removed asterisks fromFormLabelfor "Contract Addresses" and "To Address".webhookTypes.ts, updated validation to allow optional addresses and improved error messages for invalid inputs.Summary by CodeRabbit
Bug Fixes
New Features