-
Notifications
You must be signed in to change notification settings - Fork 544
docs: update webhook parameter filtering types and add example #7295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update webhook parameter filtering types and add example #7295
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7295 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 909 909
Lines 58673 58673
Branches 4158 4158
=======================================
Hits 32607 32607
Misses 25959 25959
Partials 107 107
🚀 New features to boost your workflow:
|
size-limit report 📦
|
299e713
to
766e444
Compare
766e444
to
0e3392b
Compare
ebd415e
to
da9ceef
Compare
b6e40de
to
8fe01c7
Compare
340a10b
to
a176c4d
Compare
Merge activity
|
# [Portal] Fix: Update webhook parameter filtering documentation ## Notes for the reviewer This PR updates the webhook filtering documentation to: 1. Correct the type definition for `params` in both events and transactions filters 2. Add a practical example showing how to filter for `Transfer` events with specific parameters ## How to test Review the updated documentation to ensure the type definitions are correct and the new example is clear and helpful. <!-- start pr-codex --> --- ## PR-Codex overview This PR updates the `params` property in the webhooks filtering configuration to allow for stricter type definitions, changing it from `Record<string, any>` to `Record<string, string | number>`. It also provides an example of how to filter `Transfer` events. ### Detailed summary - Changed `params` type in the `webhooks` filtering from `Record<string, any>` to `Record<string, string | number>`. - Updated `params` type in the `signatures` object from `string[]` to `Record<string, string | number>`. - Added an example for filtering `Transfer` events with a specific `from` address. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
a176c4d
to
62a3cd8
Compare
8fe01c7
to
2d15cd6
Compare
[Portal] Fix: Update webhook parameter filtering documentation
Notes for the reviewer
This PR updates the webhook filtering documentation to:
params
in both events and transactions filtersTransfer
events with specific parametersHow to test
Review the updated documentation to ensure the type definitions are correct and the new example is clear and helpful.
PR-Codex overview
This PR focuses on updating the
params
property in the webhook filtering configuration to allow for more specific data types. It enhances the ability to filter decoded parameters by changing the type fromany
tostring | number
, ensuring stricter data handling.Detailed summary
params?: Record<string, any>
toparams?: Record<string, string | number>
in the filtering configuration.params
property under thesignatures
object to the same type.Transfer
events, specifying thefrom
address.