Fix a bug that causes tcp/receive/duplicate|out_of_order not working #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add TCP Tail Loss Recovery Probes sampler via BPF * Add TCP Retransmit timeout sampler via BPF
rittme
approved these changes
Jan 6, 2022
Contributor
rittme
left a comment
rittme
left a comment
There was a problem hiding this comment.
Thank you for finding and fixing this!
brayniac
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
tcp/receive/duplicate and tcp/receive/out_of_order metrics count are always 0.
Even when there are actually duplicated or out of order packets in testing.
Solution
This is caused by comparing u32 against 0 in the code, and the conditions are never met.
The fix is to compare them properly as signed integer.
Result
In testing, now tcp/receive/duplicate and tcp/receive/out_of_order work as expected.