Skip to content

[BUGFIX] use random for NONE_HASH only when PYTHONHASHSEED not set #17088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2025
Merged

[BUGFIX] use random for NONE_HASH only when PYTHONHASHSEED not set #17088

merged 1 commit into from
Apr 26, 2025

Conversation

andyxning
Copy link
Contributor

According to the comments, NONE_HASH can only use random bytes when PYTHONHASHSEED is not set. For now, the implementation is in the opposite.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 24, 2025
DarkLight1337
DarkLight1337 approved these changes Apr 26, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) April 26, 2025 12:53
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Apr 26, 2025
@DarkLight1337 DarkLight1337 merged commit dc2ceca into vllm-project:main Apr 26, 2025
61 checks passed
@andyxning andyxning deleted the bugfix_use_random_for_NONE_HASH_only_when_PYTHONHASHSEED_not_set branch April 26, 2025 14:41
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Apr 29, 2025
@andyxning @dbyoung18
[BUGFIX] use random for NONE_HASH only when PYTHONHASHSEED not set (v…
f51f5fc 
…llm-project#17088)

Signed-off-by: Andy Xie <[email protected]>
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Apr 29, 2025
@andyxning @lk-chen
[BUGFIX] use random for NONE_HASH only when PYTHONHASHSEED not set (v…
ac4e84c 
…llm-project#17088)

Signed-off-by: Andy Xie <[email protected]>
adobrzyn pushed a commit to HabanaAI/vllm-fork that referenced this pull request Apr 30, 2025
@andyxning @adobrzyn
[BUGFIX] use random for NONE_HASH only when PYTHONHASHSEED not set (v…
383b5ab 
…llm-project#17088)

Signed-off-by: Andy Xie <[email protected]>
Signed-off-by: Agata Dobrzyniewicz <[email protected]>
@andyxning andyxning mentioned this pull request May 9, 2025
Merged
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@andyxning
[BUGFIX] use random for NONE_HASH only when PYTHONHASHSEED not set (v…
abe4ca2 
…llm-project#17088)

Signed-off-by: Andy Xie <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
@ckhordiasma ckhordiasma mentioned this pull request May 14, 2025
Merged
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@andyxning
[BUGFIX] use random for NONE_HASH only when PYTHONHASHSEED not set (v…
3d2244f 
…llm-project#17088)

Signed-off-by: Andy Xie <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@andyxning @minpeter
[BUGFIX] use random for NONE_HASH only when PYTHONHASHSEED not set (v…
ff511cb 
…llm-project#17088)

Signed-off-by: Andy Xie <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyxning @DarkLight1337