Skip to content

[UT] Add ut for none hash #17892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2025
Merged

[UT] Add ut for none hash #17892

merged 1 commit into from
May 15, 2025

Conversation

andyxning
Copy link
Contributor

This is a complement PR for adding ut for the generation logic of NONE_HASH correction in #17088

@github-actions GitHub Actions
Copy link

github-actions bot commented May 9, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added documentation Improvements or additions to documentation ci/build frontend multi-modality Related to multi-modality (#4194) structured-output speculative-decoding v1 labels May 9, 2025
@mergify mergify bot added tpu Related to Google TPUs tool-calling labels May 9, 2025
@andyxning andyxning force-pushed the add_ut_for_NONE_HASH branch from 15ccd72 to 8c151a7 Compare May 9, 2025 09:13
@mergify mergify bot removed the tpu Related to Google TPUs label May 9, 2025
@andyxning andyxning force-pushed the add_ut_for_NONE_HASH branch 2 times, most recently from 87baa14 to e3cc508 Compare May 9, 2025 09:55
@andyxning andyxning force-pushed the add_ut_for_NONE_HASH branch from 905c15d to a6405f7 Compare May 14, 2025 10:02
@DarkLight1337 DarkLight1337 removed documentation Improvements or additions to documentation structured-output frontend speculative-decoding multi-modality Related to multi-modality (#4194) tool-calling labels May 14, 2025
@andyxning andyxning force-pushed the add_ut_for_NONE_HASH branch 2 times, most recently from 4103243 to 08dc63e Compare May 14, 2025 13:39
@andyxning andyxning force-pushed the add_ut_for_NONE_HASH branch from 08dc63e to ec009ab Compare May 15, 2025 02:39
@DarkLight1337 DarkLight1337 merged commit 420caf7 into vllm-project:main May 15, 2025
15 checks passed
@andyxning andyxning deleted the add_ut_for_NONE_HASH branch May 15, 2025 05:48
zzzyq pushed a commit to zzzyq/vllm that referenced this pull request May 24, 2025
@andyxning
[UT] Add ut for none hash (vllm-project#17892)
8e6df6f 
Signed-off-by: Andy Xie <[email protected]>
Signed-off-by: Yuqi Zhang <[email protected]>
minpeter pushed a commit to minpeter/vllm that referenced this pull request Jun 24, 2025
@andyxning @minpeter
[UT] Add ut for none hash (vllm-project#17892)
549ef84 
Signed-off-by: Andy Xie <[email protected]>
Signed-off-by: minpeter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon

@comaniac comaniac Awaiting requested review from comaniac

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyxning @comaniac @DarkLight1337