Skip to content

refactor: set NestedHVEnabled only when requested or true#554

Merged
JenGoldstrich merged 2 commits intomainfrom
fix/nested-hardware-virtualization
Aug 28, 2025
Merged

refactor: set NestedHVEnabled only when requested or true#554
JenGoldstrich merged 2 commits intomainfrom
fix/nested-hardware-virtualization

Conversation

@tenthirtyam
Copy link
Copy Markdown
Collaborator

Description

Adds a conditional check when setting the nested virtualization flag, which helps avoid unnecessary configuration when the feature is not enabled.

Documentation updates:

  • Removed the default value note ("Defaults to false.") for the NestedHV option from the documentation in both .web-docs/components/builder/vsphere-clone/README.md and .web-docs/components/builder/vsphere-iso/README.md to keep the documentation concise and avoid redundancy. [1] [2]
  • Removed the same default value note from the struct definition in builder/vsphere/common/step_hardware.go.
  • Updated the Configure method in builder/vsphere/driver/vm.go to only set NestedHVEnabled in the VM configuration when NestedHV is true, preventing unnecessary configuration when nested virtualization is not requested.

Resolved Issues

Rollback Plan

Revert commit.

Changes to Security Controls

None.

@tenthirtyam tenthirtyam added this to the v2.1.0 milestone Aug 20, 2025
@tenthirtyam tenthirtyam self-assigned this Aug 20, 2025
@tenthirtyam tenthirtyam added the refactor Refactor label Aug 20, 2025
@tenthirtyam tenthirtyam requested a review from a team as a code owner August 20, 2025 18:41
Signed-off-by: Ryan Johnson <ryan.johnson@broadcom.com>
@tenthirtyam tenthirtyam force-pushed the fix/nested-hardware-virtualization branch from 7484f38 to cf49ae0 Compare August 20, 2025 18:47
@JenGoldstrich JenGoldstrich merged commit 43006a6 into main Aug 28, 2025
14 checks passed
@JenGoldstrich JenGoldstrich deleted the fix/nested-hardware-virtualization branch August 28, 2025 00:18
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

refactor Refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants