Skip to content

refactor: set NestedHVEnabled only when requested or true #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JenGoldstrich merged 2 commits into from
Aug 28, 2025
Merged

refactor: set NestedHVEnabled only when requested or true #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
875f69a
Only set NestedHVEnabled if requested
nneul Aug 16, 2025
cf49ae0
refactor: set `NestedHVEnabled` only when requested or `true`
tenthirtyam Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .web-docs/components/builder/vsphere-clone/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,7 +987,6 @@ wget http://{{ .HTTPIP }}:{{ .HTTPPort }}/foo/bar/preseed.cfg
for examples of profile names. Defaults to none.

- `NestedHV` (bool) - Enable nested hardware virtualization for the virtual machine.
Defaults to `false`.

- `firmware` (string) - The firmware for the virtual machine.

Expand Down
1 change: 0 additions & 1 deletion .web-docs/components/builder/vsphere-iso/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@ wget http://{{ .HTTPIP }}:{{ .HTTPPort }}/foo/bar/preseed.cfg
for examples of profile names. Defaults to none.

- `NestedHV` (bool) - Enable nested hardware virtualization for the virtual machine.
Defaults to `false`.

- `firmware` (string) - The firmware for the virtual machine.

Expand Down
1 change: 0 additions & 1 deletion builder/vsphere/common/step_hardware.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ type HardwareConfig struct {
// for examples of profile names. Defaults to none.
VGPUProfile string `mapstructure:"vgpu_profile"`
// Enable nested hardware virtualization for the virtual machine.
// Defaults to `false`.
NestedHV bool `mapstructure:"NestedHV"`
// The firmware for the virtual machine.
//
Expand Down
4 changes: 3 additions & 1 deletion builder/vsphere/driver/vm.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,7 +608,9 @@ func (vm *VirtualMachineDriver) Configure(config *HardwareConfig) error {
confSpec.MemoryAllocation = &ramSpec

confSpec.MemoryReservationLockedToMax = &config.RAMReserveAll
confSpec.NestedHVEnabled = &config.NestedHV
if config.NestedHV {
confSpec.NestedHVEnabled = &config.NestedHV
}

confSpec.CpuHotAddEnabled = &config.CpuHotAddEnabled
confSpec.MemoryHotAddEnabled = &config.MemoryHotAddEnabled
Expand Down
1 change: 0 additions & 1 deletion docs-partials/builder/vsphere/common/HardwareConfig-not-required.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
for examples of profile names. Defaults to none.

- `NestedHV` (bool) - Enable nested hardware virtualization for the virtual machine.
Defaults to `false`.

- `firmware` (string) - The firmware for the virtual machine.

Expand Down
Loading