Skip to content

Feat/Custom Policy Template -- Feature Complete#334

Merged
shobha2626 merged 1 commit intomainfrom
feat/custom-policy-template
Jan 15, 2024
Merged

Feat/Custom Policy Template -- Feature Complete#334
shobha2626 merged 1 commit intomainfrom
feat/custom-policy-template

Conversation

@GilTeraSky
Copy link
Copy Markdown
Contributor

@GilTeraSky GilTeraSky commented Nov 15, 2023 •
edited by shobha2626
Loading

  1. What this PR does / why we need it:
    This PR includes the complete implementation of a Custom Policy Template.

Screenshot 2024-01-10 at 11 42 59 AM

Screenshot 2024-01-10 at 11 54 10 AM

Screenshot 2024-01-10 at 11 54 20 AM

Screenshot 2024-01-10 at 11 54 29 AM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7a83d88) 25.10% compared to head (dab40e0) 25.10%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #334   +/-   ##
=======================================
  Coverage   25.10%   25.10%           
=======================================
  Files         191      191           
  Lines       16482    16483    +1     
=======================================
+ Hits         4137     4138    +1     
  Misses      12131    12131           
  Partials      214      214

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

aqstack
aqstack previously approved these changes Nov 16, 2023
View reviewed changes
vrabbi
vrabbi previously approved these changes Nov 20, 2023
View reviewed changes
@GilTeraSky GilTeraSky dismissed stale reviews from vrabbi and aqstack via 24e7284 November 21, 2023 09:08
@GilTeraSky GilTeraSky force-pushed the feat/custom-policy-template branch from 401e75f to 24e7284 Compare November 21, 2023 09:08
shobha2626
shobha2626 previously approved these changes Nov 21, 2023
View reviewed changes
vrabbi
vrabbi previously approved these changes Nov 21, 2023
View reviewed changes
Copy link
Copy Markdown

@vrabbi vrabbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GilTeraSky GilTeraSky dismissed stale reviews from vrabbi and shobha2626 via c8c39e3 November 21, 2023 09:48
@GilTeraSky GilTeraSky force-pushed the feat/custom-policy-template branch 3 times, most recently from db262ba to 4ea4e4f Compare November 22, 2023 16:32
vrabbi
vrabbi previously approved these changes Nov 22, 2023
View reviewed changes
@vrabbi vrabbi requested a review from shobha2626 November 22, 2023 16:33
shobha2626
shobha2626 reviewed Nov 22, 2023
View reviewed changes
@shobha2626
Copy link
Copy Markdown
Contributor

shobha2626 commented Nov 22, 2023

@GilTeraSky can we please have a meaningful commit message, this is required because it is helpful while auto generation the release notes

@GilTeraSky GilTeraSky force-pushed the feat/custom-policy-template branch from 7c2acee to 0aa8b4b Compare November 23, 2023 08:58
shobha2626
shobha2626 previously approved these changes Nov 23, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@shobha2626 shobha2626 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ramya-bangera
ramya-bangera suggested changes Nov 28, 2023
View reviewed changes
@GilTeraSky GilTeraSky force-pushed the feat/custom-policy-template branch from 0aa8b4b to 46f9c4b Compare November 29, 2023 09:21
ramya-bangera
ramya-bangera previously approved these changes Nov 30, 2023
View reviewed changes
shobha2626
shobha2626 previously approved these changes Nov 30, 2023
View reviewed changes
@shobha2626 shobha2626 dismissed stale reviews from ramya-bangera and themself via d325550 January 10, 2024 04:50
@shobha2626 shobha2626 force-pushed the feat/custom-policy-template branch 2 times, most recently from d325550 to f7e2b15 Compare January 10, 2024 06:15
@shobha2626
Copy link
Copy Markdown
Contributor

shobha2626 commented Jan 10, 2024

Validated the tests and CRUD operation through terraform script

@shobha2626 shobha2626 requested a review from ankitsny January 10, 2024 06:16
ankitsny
ankitsny previously approved these changes Jan 10, 2024
View reviewed changes
ramya-bangera
ramya-bangera reviewed Jan 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ramya-bangera ramya-bangera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

@shobha2626 shobha2626 force-pushed the feat/custom-policy-template branch from f7e2b15 to dc4951a Compare January 11, 2024 09:51
ramya-bangera
ramya-bangera previously approved these changes Jan 11, 2024
View reviewed changes
@GilTeraSky @shobha2626
Added custom policy template resource
dab40e0 
Signed-off-by: GilTS <gil@terasky.com>
@shobha2626 shobha2626 force-pushed the feat/custom-policy-template branch from dc4951a to dab40e0 Compare January 11, 2024 10:15
vmw-vjn
vmw-vjn reviewed Jan 12, 2024
View reviewed changes
Copy link
Copy Markdown

@vmw-vjn vmw-vjn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why we are not appending on docs/guides/tanzu-mission-control_policy.md as part of PR?
I think we should illustrate custom policy template creation and then usage of said custom policy template as part of custom policy in said guide.

@shobha2626
Copy link
Copy Markdown
Contributor

shobha2626 commented Jan 12, 2024 •
edited
Loading

Any reason why we are not appending on docs/guides/tanzu-mission-control_policy.md as part of PR? I think we should illustrate custom policy template creation and then usage of said custom policy template as part of custom policy in said guide.

@vmw-vjn this PR is for custom policy template resource alone. it is consumed by custom policy assignment resource, implemented in PR here.

Will add the guide doc as part of the acceptance test PR for custom policy assignment.

@shobha2626 shobha2626 merged commit 33c27c9 into main Jan 15, 2024
@tenthirtyam tenthirtyam deleted the feat/custom-policy-template branch November 13, 2024 06:30
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 17, 2024

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ankitsny ankitsny Awaiting requested review from ankitsny

6 more reviewers

@shobha2626 shobha2626 shobha2626 left review comments

@vmw-vjn vmw-vjn vmw-vjn left review comments

@sbasu31 sbasu31 sbasu31 approved these changes

@ramya-bangera ramya-bangera ramya-bangera approved these changes

@aqstack aqstack aqstack left review comments

@vrabbi vrabbi vrabbi left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@GilTeraSky @codecov-commenter @shobha2626 @sbasu31 @ankitsny @aqstack @vrabbi @ramya-bangera @vmw-vjn