Feat/Custom Policy Assignment -- Feature Complete#347
Conversation
|
Please squash the commits into meaningful commit message |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
+ Coverage 25.25% 25.29% +0.04%
==========================================
Files 191 192 +1
Lines 16532 16657 +125
==========================================
+ Hits 4175 4214 +39
- Misses 12139 12225 +86
Partials 218 218 ☔ View full report in Codecov by Sentry. |
32a8906 to
ac16875
Compare
ac16875 to
ef1d21e
Compare
|
@shobha2626 - I could not find the acceptance tests , is it part of separate PR? |
@ramya-bangera acceptance test was not done as part of this PR. Will be opening a new PR with acceptance test changes |
Signed-off-by: GilTS <gil@terasky.com>
ef1d21e to
013cd5d
Compare
|
Added acceptance test as part of the PR - #371 |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
What this PR does / why we need it:
This PR includes the complete implementation of a Custom Policy Assignment.
Which issue(s) this PR fixes
Additional information
a. It was needed to modify the InputData struct to support custom policy with custom template.
b. Parameters field is a string because it is a dynamic field, therefore it will be populate with JSON encoded string for the
parameters.
c. On plan phase, parameters will be validated according to the OpenAPIV3 Schema that is defined for the custom template.
Special notes for your reviewer