Skip to content

Feat/Custom Policy Assignment -- Feature Complete#347

Merged
shobha2626 merged 1 commit intomainfrom
feat/custom-policy-assignment
Jan 17, 2024
Merged

Feat/Custom Policy Assignment -- Feature Complete#347
shobha2626 merged 1 commit intomainfrom
feat/custom-policy-assignment

Conversation

@GilTeraSky
Copy link
Copy Markdown
Contributor

  1. What this PR does / why we need it:
    This PR includes the complete implementation of a Custom Policy Assignment.

  2. Which issue(s) this PR fixes

  3. Additional information
    a. It was needed to modify the InputData struct to support custom policy with custom template.
    b. Parameters field is a string because it is a dynamic field, therefore it will be populate with JSON encoded string for the
    parameters.
    c. On plan phase, parameters will be validated according to the OpenAPIV3 Schema that is defined for the custom template.

  4. Special notes for your reviewer

@shobha2626
Copy link
Copy Markdown
Contributor

Please squash the commits into meaningful commit message

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 106 lines in your changes are missing coverage. Please review.

Comparison is base (d0d6414) 25.25% compared to head (013cd5d) 25.29%.

Files Patch % Lines
...ces/policy/kind/custom/recipe/tmc_custom_schema.go 41.05% 56 Missing ⚠️
...ernal/resources/policy/kind/custom/input_schema.go 0.00% 31 Missing ⚠️
...ternal/resources/policy/kind/custom/spec_schema.go 0.00% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   25.25%   25.29%   +0.04%     
==========================================
  Files         191      192       +1     
  Lines       16532    16657     +125     
==========================================
+ Hits         4175     4214      +39     
- Misses      12139    12225      +86     
  Partials      218      218              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shobha2626 shobha2626 force-pushed the feat/custom-policy-assignment branch 3 times, most recently from 32a8906 to ac16875 Compare January 11, 2024 04:45
shobha2626
shobha2626 previously approved these changes Jan 11, 2024
ankitsny
ankitsny previously approved these changes Jan 11, 2024
@shobha2626 shobha2626 dismissed stale reviews from ankitsny and themself via ef1d21e January 11, 2024 10:10
@shobha2626 shobha2626 force-pushed the feat/custom-policy-assignment branch from ac16875 to ef1d21e Compare January 11, 2024 10:10
@ramya-bangera
Copy link
Copy Markdown
Contributor

@shobha2626 - I could not find the acceptance tests , is it part of separate PR?

@shobha2626
Copy link
Copy Markdown
Contributor

@shobha2626 - I could not find the acceptance tests , is it part of separate PR?

@ramya-bangera acceptance test was not done as part of this PR. Will be opening a new PR with acceptance test changes

Signed-off-by: GilTS <gil@terasky.com>
@shobha2626 shobha2626 force-pushed the feat/custom-policy-assignment branch from ef1d21e to 013cd5d Compare January 17, 2024 05:28
@shobha2626
Copy link
Copy Markdown
Contributor

Added acceptance test as part of the PR - #371

@shobha2626 shobha2626 merged commit 47745de into main Jan 17, 2024
@tenthirtyam tenthirtyam deleted the feat/custom-policy-assignment branch November 13, 2024 06:30
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants