Skip to content

EKS wait for management cluster and pinniped to be healthy and set kubeconfig when wait_for_kubeconfig is set to true#353

Merged
sreenivasmrpivot merged 8 commits intomainfrom
feature/eks_wait_for_cluster_healthy
Jan 19, 2024
Merged

EKS wait for management cluster and pinniped to be healthy and set kubeconfig when wait_for_kubeconfig is set to true#353
sreenivasmrpivot merged 8 commits intomainfrom
feature/eks_wait_for_cluster_healthy

Conversation

@sreenivasmrpivot
Copy link
Copy Markdown
Contributor

  1. What this PR does / why we need it:
    EKS wait for management cluster and pinniped to be healthy and set kubeconfig when wait_for_kubeconfig is set to true

  2. Which issue(s) this PR fixes

     (optional, in `fixes #<issue number>` format, will close the issue(s) when PR gets merged):
    
     Fixes # TMC-43744
    
  3. Additional information

  4. Special notes for your reviewer

@vmwclabot
Copy link
Copy Markdown

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Dec 14, 2023

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

Comparison is base (4ac75a1) 25.28% compared to head (c947580) 25.28%.
Report is 4 commits behind head on main.

Files Patch % Lines
internal/resources/ekscluster/data_source.go 16.66% 40 Missing ⚠️
...ternal/resources/ekscluster/resource_ekscluster.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #353   +/-   ##
=======================================
  Coverage   25.28%   25.28%           
=======================================
  Files         189      189           
  Lines       16345    16399   +54     
=======================================
+ Hits         4133     4147   +14     
- Misses      11998    12038   +40     
  Partials      214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vmwclabot
Copy link
Copy Markdown

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Copy Markdown

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Copy link
Copy Markdown
Contributor

@asutoshpalai asutoshpalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also please add tests to internal/resources/ekscluster/resource_ekscluster_test.go?

@vmwclabot
Copy link
Copy Markdown

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwclabot
Copy link
Copy Markdown

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

asutoshpalai
asutoshpalai previously approved these changes Dec 18, 2023
Copy link
Copy Markdown
Contributor

@asutoshpalai asutoshpalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor code style comments.

@vmwclabot
Copy link
Copy Markdown

@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@sreenivasmrpivot sreenivasmrpivot merged commit 88ddf24 into main Jan 19, 2024
@tenthirtyam tenthirtyam deleted the feature/eks_wait_for_cluster_healthy branch November 13, 2024 06:33
@github-actions
Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dco-required DCO Required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants