EKS wait for management cluster and pinniped to be healthy and set kubeconfig when wait_for_kubeconfig is set to true#353
Conversation
|
@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
=======================================
Coverage 25.28% 25.28%
=======================================
Files 189 189
Lines 16345 16399 +54
=======================================
+ Hits 4133 4147 +14
- Misses 11998 12038 +40
Partials 214 214 ☔ View full report in Codecov by Sentry. |
|
@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
|
@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
asutoshpalai
left a comment
There was a problem hiding this comment.
Can you also please add tests to internal/resources/ekscluster/resource_ekscluster_test.go?
|
@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
|
@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
asutoshpalai
left a comment
There was a problem hiding this comment.
Minor code style comments.
|
@sreenivasmrpivot, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
What this PR does / why we need it:
EKS wait for management cluster and pinniped to be healthy and set kubeconfig when wait_for_kubeconfig is set to true
Which issue(s) this PR fixes
Additional information
Special notes for your reviewer