Merged
Conversation
added 2 commits
January 14, 2025 11:16
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 13 commits
January 14, 2025 11:22
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
commented
Jan 14, 2025
adambarreiro
commented
Jan 14, 2025
adambarreiro
commented
Jan 14, 2025
adambarreiro
commented
Jan 14, 2025
added 6 commits
January 15, 2025 11:21
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 3 commits
January 16, 2025 11:13
Didainius
reviewed
Jan 16, 2025
lvirbalas
reviewed
Jan 16, 2025
lvirbalas
reviewed
Jan 16, 2025
Didainius
reviewed
Jan 16, 2025
Signed-off-by: abarreiro <abarreiro@vmware.com>
Didainius
reviewed
Jan 16, 2025
Didainius
reviewed
Jan 16, 2025
added 6 commits
January 16, 2025 14:14
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 4 commits
January 16, 2025 15:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the basic elements to bootstrap the VCFA provider taken from original VCD Provider. A minimal set of core functions have been moved and refactored to make the new provider core to work.
A simple data source
vcfa_tm_versionhas been also migrated, to test that everything works.Tests
Both
make testunitandmake testaccwork. Launching tests with the IDE also work.Manual test
Clone the fork:
Create a main.tf file with the following:
Then you can do
terraform initandterraform applyas usual. The operation should succeed.