-
Notifications
You must be signed in to change notification settings - Fork 6
Bootstrapping VCFA provider #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 51 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
d0b65a3
Init
c740b17
Add github stuff
621c5b0
Typos
f17a849
Goreleaser
e813768
Fix main
ea2dacb
Tests not run
50805ed
tests pass
91962a4
Docs
437305c
Tests pass
38088c4
#
7492085
Add workflows
f49cc5d
Add workflows
1a9de59
Fix modules
f2a14ac
#
2bc0db4
#
6ff4342
#
9f204f5
Remove stuff
ffd55f5
Adjust docs
03c1e35
Adjust docs
21d63f3
Adjust docs
9774ef8
README
771119c
README
1f53da4
README
9410316
Change vCD to VCFA
4d9361a
Remove VCD
66c1d68
Remove Vcd.Org
00d868a
Apply suggestions
f6bb57a
Add website.erb
682cc9c
Add website.erb
1ba2a71
#
a73fe0a
#
ca9a910
Suggestions
99813f5
Suggestions
b77426e
#
90a207b
#
1bc50fb
#
d9737d9
#
13ec4fa
Fix
0e4b0a5
Fix
a295f44
#
deeece1
#
91db01e
Suggestions
8d6a93b
#
6f6489f
#
a2dddcc
#
fd6044b
#
3209a90
#
7c91149
#
8896bf6
#
9b2d33d
#
2d436bc
Improve readme
d95998f
#
ddf9523
nit
3766629
#
ea9f77c
#
c1ff68f
#
3ae3e35
#
f098ec4
Fix sample config
4cc4941
#
df48439
#
72ee7cb
Rename useVcdConnectionCache
84f5776
Remove links
289efed
typo
ad87734
typo
ecd567b
Changelog
ba58b81
Changelog
45e0cb1
Changelog
fc78b1f
Changelog
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Handling of CHANGELOG entries | ||
|
|
||
| * All PRs, instead of updating CHANGELOG.md directly, will create individual files in a directory .changes/$version (The version is the same contained in the VERSION file) | ||
| * The files will be named `xxx-section_name.md`, where xxx is the PR number, and `section_name` is one of | ||
| * features | ||
| * improvements | ||
| * bug-fixes | ||
| * deprecations | ||
| * notes | ||
| * removals | ||
|
|
||
| * The changes files must NOT contain the header | ||
|
|
||
| * You can update the file `.changes/sections` to add more headers | ||
| * To see the full change set for the current version (or an old one), use `./scripts/make-changelog.sh [version]` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| # This script is used at the start of a new release cycle, to | ||
| # initialize the CHANGELOG | ||
| # Run at the top of the repository, as '.changes/init.sh' | ||
|
|
||
| version=$1 | ||
| if [ -z "${version}" ] | ||
| then | ||
| if [ ! -f VERSION ] | ||
| then | ||
| echo "File ./VERSION not found" | ||
| echo "run this command from the repository root directory as .changes/init.sh" | ||
| echo "" | ||
| echo "or supply a version on the command line: ./init.sh v1.0.0" | ||
| exit 1 | ||
| fi | ||
|
|
||
| version_from_file=$(cat VERSION | tr -d '\n' | tr -d '\r' ) | ||
|
|
||
| if [ -z "$version_from_file" ] | ||
| then | ||
| echo "No version found in ./VERSION file" | ||
| exit 1 | ||
| fi | ||
| version=$version_from_file | ||
| fi | ||
|
|
||
| starts_with_v=$(echo ${version} | grep '^v') | ||
| if [ -n "$starts_with_v" ] | ||
| then | ||
| version=$(echo ${version} | tr -d 'v') | ||
| fi | ||
|
|
||
| echo "Copy the following lines at the top of CHANGELOG.md" | ||
| echo "" | ||
| echo "" | ||
| echo "## ${version} (Unreleased)" | ||
| echo "" | ||
| echo "Changes in progress for v${version} are available at [.changes/v${version}](https://github.com/vmware/terraform-provider-vcfa/tree/main/.changes/v${version}) until the release." | ||
| echo "" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| features | ||
| experimental-features | ||
| improvements | ||
| bug-fixes | ||
| deprecations | ||
| notes | ||
| removals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # These owners will be the default owners for everything in the repo. Unless a later match takes | ||
| # precedence all these users will be requested for review when someone opens a pull request. | ||
| * @lvirbalas @Didainius @adambarreiro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| --- | ||
| name: Bug Report | ||
| about: If something isn't working as expected in Terraform VCFA Provider | ||
|
|
||
| --- | ||
|
|
||
| Hello, | ||
|
|
||
| Thank you for opening an issue. Please note that we try to keep the Terraform VCFA Provider issue tracker reserved | ||
| for bug reports and feature requests. For general Terraform usage questions, please see: | ||
| https://www.terraform.io/community.html. | ||
|
|
||
| ### Terraform Version | ||
| Run `terraform -v` to show the version. If you are not running the latest version of Terraform, please upgrade because your issue may have already been fixed. | ||
|
|
||
| ### Affected Resource(s) | ||
| Please list the resources as a list, for example: | ||
| - vcfa_org | ||
| - vcfa_region | ||
|
|
||
| If this issue appears to affect multiple resources, it may be an issue with Terraform's core, so please mention this. | ||
|
|
||
| ### Terraform Configuration Files | ||
|
|
||
| ```hcl | ||
| Copy-paste your Terraform configurations here. Please **shrink HCL replicating the bug to minimum** | ||
| without modules. It will help us to respond and replicate the problem quicker. It may also uncover | ||
| some HCL error while doing so. | ||
|
|
||
| For bigger configs you may use [Gist(s)](https://gist.github.com) or a service like Dropbox and | ||
| share a link to the ZIP file. | ||
| ``` | ||
|
|
||
| ### Debug Output | ||
| Please provide a link to GitHub [Gist(s)](https://gist.github.com) containing complete debug | ||
| output. You can enable debug by using the commands below: | ||
| ```shell | ||
| export TF_LOG_PATH=tf.log | ||
| export TF_LOG=TRACE | ||
| export GOVCD_LOG_FILE=go-vcloud-director.log | ||
| export GOVCD_LOG=true | ||
| ``` | ||
|
|
||
| On Windows the command instead of `export` is `set`. | ||
|
|
||
| Replicate the issue after setting the environment variables listed above and it should create two | ||
| new files in the working directory: `tf.log` and `go-vcloud-director.log`. The `tf.log` is a general | ||
| Terraform debug log (more information about it is in | ||
| https://www.terraform.io/docs/internals/debugging.html) while the `go-vcloud-director.log` is a | ||
| specific log file for `terraform-provider-vcfa` containing debug information about performed API | ||
| calls. Please attach both of them to your [Gist](https://gist.github.com). | ||
|
|
||
| ### Panic Output | ||
| If Terraform produced a panic, please provide a link to a GitHub Gist containing the output of the `crash.log`. | ||
|
|
||
| ### Expected Behavior | ||
| What should have happened? | ||
|
|
||
| ### Actual Behavior | ||
| What actually happened? | ||
|
|
||
| ### Steps to Reproduce | ||
| Please list the steps required to reproduce the issue, for example: | ||
| 1. `terraform apply` | ||
|
|
||
| ### User Access rights | ||
| Information about user used. Role and/or more exact rights if it is customized. | ||
|
|
||
| ### Important Factoids | ||
| Is there anything atypical about your accounts that we should know? | ||
|
|
||
| ### References | ||
| Are there any other GitHub issues (open or closed) or Pull Requests that should be linked here? For example: | ||
| - Issue #0000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| --- | ||
| name: 🚀 Feature Request | ||
| about: I have a suggestion (and might want to implement myself 🙂)! | ||
| labels: enhancement | ||
| --- | ||
|
|
||
| <!--- Please keep this note for the community ---> | ||
|
|
||
| ### Community Note | ||
|
|
||
| * Please vote on this issue by adding a 👍 [reaction](https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/) to the original issue to help the community and maintainers prioritize this request | ||
| * Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request | ||
| * If you are interested in working on this issue or have submitted a pull request, please leave a comment | ||
|
|
||
| <!--- Thank you for keeping this note for the community ---> | ||
|
|
||
| ### Description | ||
|
|
||
| <!--- Please leave a helpful description of the feature request here. ---> | ||
|
|
||
| ### New or Affected Resource(s) | ||
|
|
||
| <!--- Please list the new or affected resources and data sources. ---> | ||
|
|
||
| * vcfa_XXX | ||
|
|
||
| ### Terraform Configuration (if it applies) | ||
|
|
||
| <!--- Information about code formatting: https://help.github.com/articles/basic-writing-and-formatting-syntax/#quoting-code ---> | ||
|
|
||
| ```hcl | ||
| Copy-paste your Terraform configurations here. Please **shrink HCL replicating the bug to minimum** | ||
| without modules. It will help us to respond and replicate the problem quicker. It may also uncover | ||
| some HCL error while doing so. | ||
|
|
||
| For bigger configs you may use [Gist(s)](https://gist.github.com) or a service like Dropbox and | ||
| share a link to the ZIP file. | ||
| ``` | ||
|
|
||
| ### References | ||
|
|
||
| <!--- | ||
| Information about referencing Github Issues: https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests | ||
|
|
||
| Are there any other GitHub issues (open or closed) or pull requests that should be linked here? Vendor blog posts or documentation? For example: | ||
|
|
||
| ---> | ||
|
|
||
| * Issue #0000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| blank_issues_enabled: false | ||
| contact_links: | ||
| - name: Terraform Core Bug Reports and Feature Requests | ||
| url: https://github.com/hashicorp/terraform/issues/new/choose | ||
| about: Terraform Core, which handles the Terraform configuration language, CLI commands, and resource dependency graph, has its own codebase. Bug reports and feature requests for those pieces of functionality should be directed to that repository. | ||
| - name: Terraform Language or Workflow Questions | ||
| url: https://discuss.hashicorp.com/c/terraform-core | ||
| about: Please ask and answer language or workflow related questions through the Terraform Core Community Forum. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| name: check-code | ||
| on: | ||
| push: | ||
| paths-ignore: | ||
| - '**.md' | ||
| - 'website/**' | ||
| pull_request: | ||
| paths-ignore: | ||
| - '**.md' | ||
| - 'website/**' | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Check | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| GO111MODULE: on | ||
|
|
||
| steps: | ||
|
|
||
| - name: Check out code into the Go module directory | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Set up Go 1.x | ||
| uses: actions/setup-go@v3 | ||
| with: | ||
| go-version-file: 'go.mod' | ||
|
|
||
| - name: vet | ||
| run: make vet | ||
|
|
||
| - name: static | ||
| run: make static | ||
|
|
||
| - name: test | ||
| run: make test | ||
|
|
||
| - name: tags | ||
| run: make tagverify | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| *.dll | ||
| *.exe | ||
| .DS_Store | ||
| example.tf | ||
| terraform.tfplan | ||
| terraform.tfstate | ||
| bin/ | ||
| modules-dev/ | ||
| /pkg/ | ||
| website/.vagrant | ||
| website/.bundle | ||
| website/build | ||
| website/node_modules | ||
| .vagrant/ | ||
| *.backup | ||
| ./*.tfstate | ||
| .terraform/ | ||
| *.log | ||
| *.bak | ||
| *~ | ||
| .*.swp | ||
| .idea | ||
| .vscode/ | ||
| *.iml | ||
| *.test | ||
| *.iml | ||
|
|
||
| # Ignore test coverage files | ||
| *.cover | ||
|
|
||
| vcfa_test_config*.json | ||
| vcfa/vcfa_test_config*.json | ||
| vcfa_test_config*.json | ||
| vcfa/go-vcloud-director.log | ||
| vcfa/test-artifacts | ||
| website/vendor | ||
| vcfa/org_user_pwd.txt | ||
| vcfa/vcfa_test_pass_list*.txt | ||
| tmp/ | ||
| examples/**/terraform.tfvars | ||
| examples/**/.terraform* | ||
|
|
||
| # Test exclusions | ||
| !command/test-fixtures/**/*.tfstate | ||
| !command/test-fixtures/**/.terraform/ | ||
| vcfa/*-tests-end-in-node-*-*.txt | ||
| vcfa/*-tests-planned-in-node-*-*.txt | ||
| vcfa/*-tests-processed-in-node-*-*.txt | ||
| vcfa/*-tests-retrieved-in-node-*-*.txt | ||
| vcfa/*-out-*.txt | ||
|
|
||
| # Go workspace | ||
| go.work | ||
| go.work.sum | ||
|
|
||
| # File cache directory | ||
| test-resources/cache/* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| version: 2 | ||
| before: | ||
| hooks: | ||
| - go mod tidy | ||
| builds: | ||
| - env: | ||
| # goreleaser does not work with CGO, it could also complicate | ||
| # usage by users in CI/CD systems like Terraform Cloud where | ||
| # they are unable to install libraries. | ||
| - CGO_ENABLED=0 | ||
| mod_timestamp: '{{ .CommitTimestamp }}' | ||
| flags: | ||
| - -trimpath | ||
| ldflags: | ||
| - '-s -w -X github.com/vmware/terraform-provider-vcfa/vcfa.BuildVersion={{.Env.BUILDVERSION}}' | ||
| goos: | ||
| - freebsd | ||
| - windows | ||
| - linux | ||
| - darwin | ||
| goarch: | ||
| - amd64 | ||
| - '386' | ||
| - arm | ||
| - arm64 | ||
| ignore: | ||
| - goos: darwin | ||
| goarch: '386' | ||
| binary: '{{ .ProjectName }}_v{{ .Version }}' | ||
| archives: | ||
| - format: zip | ||
| name_template: '{{ .ProjectName }}_{{ .Version }}_{{ .Os }}_{{ .Arch }}' | ||
| checksum: | ||
| name_template: '{{ .ProjectName }}_{{ .Version }}_SHA256SUMS' | ||
| algorithm: sha256 | ||
| signs: | ||
| - artifacts: checksum | ||
| args: | ||
| # if you are using this is a GitHub action or some other automated pipeline, you | ||
| # need to pass the batch flag to indicate its not interactive. | ||
| - "--batch" | ||
| - "--local-user" | ||
| - "{{ .Env.GPG_FINGERPRINT }}" # set this environment variable for your signing key | ||
| - "--output" | ||
| - "${signature}" | ||
| - "--detach-sign" | ||
| - "${artifact}" | ||
| release: | ||
| # Visit your project's GitHub Releases page to publish this release. | ||
| draft: true | ||
| changelog: | ||
| filters: | ||
| exclude: | ||
| - '^docs:' | ||
| - '^test:' | ||
| - Merge pull request | ||
| - Merge branch | ||
| - go mod tidy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ## 1.0.0 (Unreleased) | ||
|
|
||
| Changes in progress for v1.0.0 are available at [.changes/v1.0.0](https://github.com/vmware/terraform-provider-vcfa/tree/main/.changes/v1.0.0) until the release. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.