Make Content Library Item usable by tenants and support ISO/OVF files#46
Merged
adambarreiro merged 19 commits intovmware:mainfrom Mar 4, 2025
Merged
Make Content Library Item usable by tenants and support ISO/OVF files#46adambarreiro merged 19 commits intovmware:mainfrom
adambarreiro merged 19 commits intovmware:mainfrom
Conversation
added 3 commits
February 24, 2025 10:42
adambarreiro
changed the title
added 3 commits
February 25, 2025 12:59
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
changed the title
added 4 commits
February 26, 2025 16:44
added 7 commits
February 27, 2025 10:04
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
lvirbalas
reviewed
Feb 27, 2025
lvirbalas
approved these changes
Mar 3, 2025
Merged
Didainius
approved these changes
Mar 4, 2025
lvirbalas
reviewed
Mar 5, 2025
| * `content_library_id` - (Required) ID of the Content Library that this Content Library Item belongs to | ||
| * `file_path` - (Required) Path to the OVA/ISO to create the Content Library Item | ||
| * `content_library_id` - (Required) ID of the [Content Library](/providers/vmware/vcfa/latest/docs/resources/content_library) that this Content Library Item belongs to | ||
| * `files_paths` - (Required) A single path to an OVA/ISO, or multiple paths for an OVF and its referenced files, to create the Content Library Item |
There was a problem hiding this comment.
Somehow missed this single letter. It should really be called file_paths. In English when a noun modifies another noun, the first one usually remains singular.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes
file_pathtofiles_pathsinvcfa_content_library_itemto allow uploading OVF files, as this use case needs to specify the "descriptor.ovf" and the other referenced files.Also, now
vcfa_content_library_itemsupports ISO files, and the resource can be used with Content Libraries of typeTENANT.Tests are updated:
TENANTcontent library and check the data sources + importTENANTcontent library and check the data sources + import. Then, logged in as a regular tenant user, does the same: uploads each type of item (OVA, ISO, OVF) and check the data sources.