Merged
Conversation
added 18 commits
February 24, 2025 10:42
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 6 commits
February 27, 2025 14:28
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
added 2 commits
March 4, 2025 14:50
Signed-off-by: abarreiro <abarreiro@vmware.com>
Signed-off-by: abarreiro <abarreiro@vmware.com>
adambarreiro
commented
Mar 4, 2025
adambarreiro
commented
Mar 4, 2025
Didainius
approved these changes
Mar 6, 2025
Contributor
Didainius
left a comment
Didainius
left a comment
There was a problem hiding this comment.
I tried out the mechanism by running a few tests and building/rebuilding them. It worked. Thanks!
added 2 commits
March 6, 2025 15:54
lvirbalas
approved these changes
Mar 13, 2025
lvirbalas
left a comment
lvirbalas
left a comment
There was a problem hiding this comment.
Let's remove those not needed TODOs and merge :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR recovers the binary testing feature that is already available in https://github.com/vmware/terraform-provider-vcd.
Binary tests run HCL files generated by the regular Acceptance tests with a real Terraform executable binary.
These tests can be prepared with
make test-binary-prepare(just creates the HCL files) or withmake test-binaryto launch them.