vdk-structlog: LTSV formatting#2887
Merged
gabrielgeorgiev1 merged 8 commits intomainfrom Nov 14, 2023
Merged
Conversation
This PR incorporates the LTSV formatting which was present in the vdk-logging-format plugin to vdk-structlog, rendering vdk-logging- format unneccessary. Testing done: unit tests cover LTSV formatting Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
for more information, see https://pre-commit.ci
murphp15
reviewed
Nov 10, 2023
projects/vdk-plugins/vdk-structlog/src/vdk/plugin/structlog/formatters.py
Outdated
Show resolved
Hide resolved
duyguHsnHsn
approved these changes
Nov 13, 2023
Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
for more information, see https://pre-commit.ci
…om:vmware/versatile-data-kit into person/gageorgiev/deprecate-logging-format Signed-off-by: Gabriel Georgiev <gageorgiev@vmware.com>
for more information, see https://pre-commit.ci
gabrielgeorgiev1
deleted the
person/gageorgiev/deprecate-logging-format
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR incorporates the LTSV formatting which was present in the vdk-logging-format plugin to vdk-structlog, rendering vdk-logging- format unneccessary.
Addresses #2812
Testing done: unit tests cover LTSV formatting