Skip to content

Remove downcast-rs usage #1513

Closed
Closed
@Robbepop

Description

@Robbepop

I just noticed that wasmi_core depends on downcast-rs for the sole purpose of providing the downcasting API via macro. Thus I deem this a very unnecessary dependency which should be removed.

In today's Rust the downcast-rs crate is only useful if there are a large number of traits that need downcasting support, for example often used in ECS systems. However, in Wasmi's case there is just the HostError trait.

It should be very easy to replace downcast-rs usage with Rust's Any type API.

Metadata

Metadata

Assignees

No one assigned

    Labels

    cleanupCleans up some region of the codebase.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions