Skip to content

Remove the downcast-rs dependency from wasmi_core #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 11, 2025

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented May 11, 2025

Closes #1513.
Blocked by #1518.

Copy link

codecov bot commented May 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.68%. Comparing base (f4c321e) to head (a80398a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/host_error.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1517      +/-   ##
==========================================
- Coverage   70.74%   70.68%   -0.07%     
==========================================
  Files         176      177       +1     
  Lines       16575    16585      +10     
==========================================
- Hits        11726    11723       -3     
- Misses       4849     4862      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Robbepop Robbepop force-pushed the rf-remove-downcast-dep branch from d0ff94f to a80398a Compare May 11, 2025 18:40
@Robbepop Robbepop merged commit d63125c into main May 11, 2025
17 of 19 checks passed
@Robbepop Robbepop deleted the rf-remove-downcast-dep branch May 11, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove downcast-rs usage
1 participant